Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add arm64 to os.machine() #45374

Merged
merged 1 commit into from
Nov 17, 2022
Merged

doc: add arm64 to os.machine() #45374

merged 1 commit into from
Nov 17, 2022

Conversation

sno2
Copy link
Contributor

@sno2 sno2 commented Nov 8, 2022

arm64 is a much more common machine name than s390x so I think it deserves a spot on in the sunlight.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. labels Nov 8, 2022
Trott
Trott approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you amend the commit message to be doc: add arm64 to os.machine() and force push to this branch?

@sno2 sno2 changed the title chore(os): add arm64 to os.machine() doc: add arm64 to os.machine() Nov 8, 2022
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2022
@nodejs-github-bot nodejs-github-bot merged commit 490c3d6 into nodejs:main Nov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 490c3d6

@sno2 sno2 deleted the patch-1 branch November 17, 2022 22:00
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@sno2 @ruyadorno
doc: add arm64 to os.machine()
4de67d1 
PR-URL: #45374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@sno2 @marco-ippolito
doc: add arm64 to os.machine()
076718d 
PR-URL: nodejs#45374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@sno2 @danielleadams
doc: add arm64 to os.machine()
7352761 
PR-URL: #45374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@sno2 @danielleadams
doc: add arm64 to os.machine()
7628ffb 
PR-URL: #45374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@sno2 @danielleadams
doc: add arm64 to os.machine()
8b44c61 
PR-URL: #45374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@sno2 @danielleadams
doc: add arm64 to os.machine()
adc9858 
PR-URL: #45374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sno2 @nodejs-github-bot @jasnell @Trott @lpinca @anonrig @cjihrig