Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No call to SetIdle() when terminating #45422

Closed
wants to merge 5 commits into from
Closed

No call to SetIdle() when terminating #45422

wants to merge 5 commits into from

Commits on Nov 11, 2022

  1. src: no call to SetIdle() when terminating 

    Calling SetIdle() when terminating is not harmless.
When node terminates due to an unhandled exception,
v8 preseves the vm state, which is JS and notifies
node through PerIsolateMessageListener(). If node
calls SetIdle() later, v8 complains because it
requires the vm state to either be EXTERNEL or IDLE
when embedder calling SetIdle().
    @ywave620
    ywave620 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    c0e3840 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. src: no call to SetIdle() when terminating 

    Fix typo

Co-authored-by: Ben Noordhuis <[email protected]>
    @ywave620 @bnoordhuis
    ywave620 and bnoordhuis authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    82f26a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. src: no call to SetIdle() when terminating 

    use fixture function to check no abort
    @ywave620
    ywave620 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6bb4c86 View commit details
    Browse the repository at this point in the history

  2. src: no call to SetIdle() when terminating 

    add assertion
    @ywave620
    ywave620 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    5a71cc0 View commit details
    Browse the repository at this point in the history

  3. src: no call to SetIdle() when terminating 

    fix judgment bug
    @ywave620
    ywave620 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    24e9448 View commit details
    Browse the repository at this point in the history