deps: update nghttp2 to 1.51.0

[targos]

Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.51.0

[nodejs-github-bot]

Review requested:

• @nodejs/http2
• @nodejs/net

[targos]

I used https://github.com/nodejs/node/blob/main/tools/update-nghttp2.sh but somehow config.h is removed while still being included by other files.

[targos]

@yashLadha is the script missing a step?

[ShogunPanda]

LGTM!

[targos]

@ShogunPanda but it doesn't work!

[ShogunPanda]

@targos I haven't executed it :) Changes on source code seemed reasonable, I was not really looking in the build script.

[yashLadha]

@yashLadha is the script missing a step?

No @targos last time I checked it worked completely fine.

Can you paste the log about what is the exact error. Might be due to recent changes in upstream dependencies.

[targos]

You can check any of the failing builds here

[gengjiawen]

@ShogunPanda but it doesn't work!

It's auto-generated, you need to copy it from build folder.

[gengjiawen]

Original config.h for v.1.51.0. But from the comment we may need to revert current one since the file comments like
/* Edited to match src/node.h. */

config.h

/* Hint to the compiler that a function never returns */
#define NGHTTP2_NORETURN __attribute__((noreturn))

/* Define to `int' if <sys/types.h> does not define. */
/* #undef ssize_t */

/* Define to 1 if you have the `std::map::emplace`. */
#define HAVE_STD_MAP_EMPLACE 1

/* Define to 1 if you have `libjansson` library. */
#define HAVE_JANSSON 1

/* Define to 1 if you have `libxml2` library. */
#define HAVE_LIBXML2 1

/* Define to 1 if you have `mruby` library. */
/* #undef HAVE_MRUBY */

/* Define to 1 if you have `neverbleed` library. */
/* #undef HAVE_NEVERBLEED */

/* sizeof(int *) */
#define SIZEOF_INT_P   8

/* sizeof(time_t) */
#define SIZEOF_TIME_T  8

/* Define to 1 if you have the `_Exit` function. */
#define HAVE__EXIT 1

/* Define to 1 if you have the `accept4` function. */
/* #undef HAVE_ACCEPT4 */

/* Define to 1 if you have the `mkostemp` function. */
#define HAVE_MKOSTEMP 1

/* Define to 1 if you have the `initgroups` function. */
#define HAVE_DECL_INITGROUPS 1

/* Define to 1 to enable debug output. */
/* #undef DEBUGBUILD */

/* Define to 1 if you want to disable threads. */
/* #undef NOTHREADS */

/* Define to 1 if you have the <arpa/inet.h> header file. */
#define HAVE_ARPA_INET_H 1

/* Define to 1 if you have the <fcntl.h> header file. */
#define HAVE_FCNTL_H 1

/* Define to 1 if you have the <inttypes.h> header file. */
#define HAVE_INTTYPES_H 1

/* Define to 1 if you have the <limits.h> header file. */
#define HAVE_LIMITS_H 1

/* Define to 1 if you have the <netdb.h> header file. */
#define HAVE_NETDB_H 1

/* Define to 1 if you have the <netinet/in.h> header file. */
#define HAVE_NETINET_IN_H 1

/* Define to 1 if you have the <pwd.h> header file. */
#define HAVE_PWD_H 1

/* Define to 1 if you have the <sys/socket.h> header file. */
#define HAVE_SYS_SOCKET_H 1

/* Define to 1 if you have the <sys/time.h> header file. */
#define HAVE_SYS_TIME_H 1

/* Define to 1 if you have the <syslog.h> header file. */
#define HAVE_SYSLOG_H 1

/* Define to 1 if you have the <time.h> header file. */
#define HAVE_TIME_H 1

/* Define to 1 if you have the <unistd.h> header file. */
#define HAVE_UNISTD_H 1

/* Define to 1 if HTTP/3 is enabled. */
/* #undef ENABLE_HTTP3 */

/* Define to 1 if you have `libbpf` library. */
/* #undef HAVE_LIBBPF */

/* Define to 1 if you have enum bpf_stats_type in linux/bpf.h. */
/* #undef HAVE_BPF_STATS_TYPE */

/* Define to 1 if you have `libngtcp2_crypto_openssl` library. */
/* #undef HAVE_LIBNGTCP2_CRYPTO_OPENSSL */

[gengjiawen]

More likely we need to revert this file than using the auto-gen one.

[targos]

@yashLadha If I run the script with the current version (./tools/update-nghttp2.sh 1.47.0), the same problem happens (config.h is deleted):

$ git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

$ ./tools/update-nghttp2.sh 1.47.0
Making temporary workspace
Fetching nghttp2 source archive
Removing everything, except lib/ and COPYING
Copying existing gyp files
Replacing existing nghttp2
All done!

Please git add nghttp2, commit the new version:

$ git add -A deps/nghttp2
$ git commit -m "deps: update nghttp2 to 1.47.0"


$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        deleted:    deps/nghttp2/lib/includes/config.h

no changes added to commit (use "git add" and/or "git commit -a")

[yashLadha]

Will check today, and close on this.

[yashLadha]

I checked the 1.47.0 tag as well and there were no include.h file present in the tree, yet the builds passed #42127. I don't see anything changed in the script.