Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: clear OpenSSL error queue after calling X509_check_private_key() #45495

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

panva
Copy link
Member

@panva panva commented Nov 17, 2022

Fixes: #45485

@panva panva added crypto Issues and PRs related to the crypto subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2022
@panva panva requested a review from anonrig November 18, 2022 05:15
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit b61603f into nodejs:main Nov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b61603f

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva panva deleted the crypto-fix-45485 branch January 2, 2023 22:07
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
4 participants