fs: set fs.watchFile poll interval to 1s

[anonrig]

I couldn't find any reference in the libuv repo for the reason or usage of 5007ms interval. Hopefully this improves the test.parallel/test-fs-watch-recursive tests.

Hopefully, fixes #45535

[mscdex]

The comment says libev not libuv. libev is the eventing library that node used to use before libuv existed.

[anonrig]

The comment says libev not libuv. libev is the eventing library that node used to use before libuv existed.

Thanks. I thought that was a typo! Is the deleted comment still valid?

[mscdex]

Is the deleted comment still valid?

Well, according to the current libev HEAD branch it still uses 5.007 seconds.

I think it would be better to look at modifying the test in question to solve the problem instead of changing timing like this that could potentially and subtly break things for people.

[anonrig]

Thank you for the awesome reference @mscdex. There are some things, you can't learn from Google. 🎉

BTW, I didn't understand the logical reasoning for the 5s delay for polling. For my own benefit, I'd appreciate it if someone can explain it to me. On the other hand, I'm going to run this branch couple of times, to validate if the flaky test repeats in this pull request.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48065/