Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] deps: V8: cherry-pick 5fe919f78321 #45587

Closed
wants to merge 1 commit into from
Closed

[v18.x] deps: V8: cherry-pick 5fe919f78321 #45587

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Nov 22, 2022 •
edited
Loading

Original commit message:

PPC: clear VXCVI before doing a conversion

This bit may not get cleared automatically and could show
results from older executed instructions.

Change-Id: I5976f9a6c5bf87b1a63ef0f35493b222729e20f6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812037
Reviewed-by: Junliang Yan <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/heads/main@{#82237}

Refs: v8/v8@5fe919f

cc @nodejs/platform-aix @nodejs/platform-ppc

Noticed from the CITGM CI runs for nodejs/citgm#905 that PPC platforms (AIX and Linux) on Node.js 18 were failing (note that the PR marks ppc as flaky so Jenkins marks the run as passing but the yarn tests failed) with:
e.g. https://ci.nodejs.org/job/citgm-smoker-nobuild/1463/nodes=rhel8-ppc64le/console

07:09:17 verbose: @yarnpkg/cli npm-test:| RuntimeError: float unrepresentable in integer range                                                                                                                                                         
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[1041]:0xe1004                                                                                                                                                          
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[1442]:0x1406a3                                                                                                                                                         
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa66c9                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa6536                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa6536                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa6536                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa6536                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[1034]:0xe0ed4                                                                                                                                                          
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[1032]:0xe0ea7                                                                                                                                                          
07:09:17 verbose:                       | at globalThis.Go.run (/home/iojs/tmp/citgm_tmp/e9a10d7f-d071-4ac5-b4c2-80b8e64ba7dd/@yarnpkg/cli/.yarn/cache/esbuild-wasm-npm-0.15.5-bc4c954bca-149219c551.zip/node_modules/esbuild-wasm/wasm_exec.js:527:23)

with this backport Linux PPC is fixed 🎉 : https://ci.nodejs.org/job/citgm-smoker/3049/nodes=rhel8-ppc64le/
Although we now get a different issue on AIX which looks to be a crash of some sort: https://ci.nodejs.org/job/citgm-smoker/3049/nodes=aix72-ppc64/console

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2022
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Nov 22, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2022
@richardlau
Copy link
Member Author

This change is already on main/v19.x as part of a V8 update.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau
Copy link
Member Author

Rebased to pick up workflow fixes on v18.x-staging.

@richardlau
Copy link
Member Author

Although we now get a different issue on AIX which looks to be a crash of some sort

I spoke with @V-for-Vasili who has been looking into issues with yarn on ppc platforms -- these crashes are in the go runtime on AIX so outside of the scope of Node.js. Merging this will at least fix the Node.js part (and will allow the yarn:cli tests to pass Node.js 18 on Linux ppc64le).

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48165/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5012/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5012/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5012/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48175/

This was referenced Nov 25, 2022
Open
Open
Open
This was referenced Nov 28, 2022
Open
Open
Open
Open
@danielleadams danielleadams force-pushed the v18.x-staging branch 2 times, most recently from 2098d7a to bac6b7d Compare January 4, 2023 17:10
@richardlau
deps: V8: cherry-pick 5fe919f78321
a6e55d5 
Original commit message:

    PPC: clear VXCVI before doing a conversion

    This bit may not get cleared automatically and could show
    results from older executed instructions.

    Change-Id: I5976f9a6c5bf87b1a63ef0f35493b222729e20f6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812037
    Reviewed-by: Junliang Yan <[email protected]>
    Commit-Queue: Milad Farazmand <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#82237}

Refs: v8/v8@5fe919f
@richardlau
Copy link
Member Author

Looks like this missed the last v18.13.0. Rebased onto current v18.x-staging.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48948/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5119/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5119/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5119/

mhdawson
mhdawson approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 13, 2023
richardlau added a commit that referenced this pull request Jan 17, 2023
@richardlau
deps: V8: cherry-pick 5fe919f78321
8dce62c 
Original commit message:

    PPC: clear VXCVI before doing a conversion

    This bit may not get cleared automatically and could show
    results from older executed instructions.

    Change-Id: I5976f9a6c5bf87b1a63ef0f35493b222729e20f6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812037
    Reviewed-by: Junliang Yan <[email protected]>
    Commit-Queue: Milad Farazmand <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#82237}

Refs: v8/v8@5fe919f
PR-URL: #45587
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@richardlau
Copy link
Member Author

Landed in 8dce62c.

@richardlau richardlau closed this Jan 17, 2023
@richardlau richardlau deleted the ppcbp branch January 17, 2023 16:51
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardlau @nodejs-github-bot @gengjiawen @mhdawson