Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v19.x backport] src,lib: group properties used as constants from util binding #45674

Closed
wants to merge 2 commits into from
Closed

[v19.x backport] src,lib: group properties used as constants from util binding #45674

wants to merge 2 commits into from

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Nov 29, 2022 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v19.x labels Nov 29, 2022
@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2022
@MoLow
Copy link
Member

MoLow commented Nov 29, 2022

why is backporting needed to v19?

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@daeyeon
Copy link
Member Author

daeyeon commented Nov 29, 2022

@MoLow #45539 (comment) It's requested. Guess it's useful for removing future conflicts upon the files changed on this patch.

@targos
Copy link
Member

targos commented Nov 29, 2022

There's a chain of commits that depend on each other which started with #45125 (marked dont-land-on-v19.x).
It would probably be better to backport 066e77a first (can be done in the same PR).

joyeecheung and others added 2 commits November 29, 2022 23:17
@joyeecheung @daeyeon
util: use private symbols in JS land directly
18d9474 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: nodejs#45379
Backport-PR-URL: nodejs#45674
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Signed-off-by: Daeyeon Jeong <[email protected]>
@daeyeon
src,lib: group properties used as constants from util binding
f06e8e9 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#45539
Backport-PR-URL: nodejs#45674
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@daeyeon
Copy link
Member Author

daeyeon commented Nov 29, 2022

@targos 066e77a is added also. PTAL

@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Dec 7, 2022
Open
10 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Open
8 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Dec 9, 2022
Open
5 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48363/

This was referenced Dec 10, 2022
Open
Open
Open
@daeyeon daeyeon added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 12, 2022
@daeyeon daeyeon added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 12, 2022
targos pushed a commit that referenced this pull request Dec 12, 2022
@joyeecheung @targos
util: use private symbols in JS land directly
8164a41 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Signed-off-by: Daeyeon Jeong <[email protected]>
targos pushed a commit that referenced this pull request Dec 12, 2022
@daeyeon @targos
src,lib: group properties used as constants from util binding
b401800 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos
Copy link
Member

targos commented Dec 12, 2022

Landed in e8406a8...b401800

@targos targos closed this Dec 12, 2022
@github-actions github-actions bot mentioned this pull request Dec 13, 2022
Open
13 tasks
targos pushed a commit that referenced this pull request Dec 13, 2022
@joyeecheung @targos
util: use private symbols in JS land directly
470384e 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Signed-off-by: Daeyeon Jeong <[email protected]>
targos pushed a commit that referenced this pull request Dec 13, 2022
@daeyeon @targos
src,lib: group properties used as constants from util binding
2fbe2f9 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@joyeecheung @danielleadams
util: use private symbols in JS land directly
aef2af3 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Signed-off-by: Daeyeon Jeong <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@daeyeon @danielleadams
src,lib: group properties used as constants from util binding
e770c80 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@joyeecheung @danielleadams
util: use private symbols in JS land directly
3d2bef5 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Signed-off-by: Daeyeon Jeong <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@daeyeon @danielleadams
src,lib: group properties used as constants from util binding
2887220 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@joyeecheung @danielleadams
util: use private symbols in JS land directly
3f18a83 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Signed-off-by: Daeyeon Jeong <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@daeyeon @danielleadams
src,lib: group properties used as constants from util binding
90e8418 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@joyeecheung @danielleadams
util: use private symbols in JS land directly
759e747 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Signed-off-by: Daeyeon Jeong <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@daeyeon @danielleadams
src,lib: group properties used as constants from util binding
714ca6d 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@joyeecheung @danielleadams
util: use private symbols in JS land directly
2bd79a3 
Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Signed-off-by: Daeyeon Jeong <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@daeyeon @danielleadams
src,lib: group properties used as constants from util binding
b02b3c8 
Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daeyeon @MoLow @nodejs-github-bot @targos @joyeecheung