Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x] deps: upgrade npm to 6.14.18 #45936

Closed
wants to merge 1 commit into from
Closed

[v14.x] deps: upgrade npm to 6.14.18 #45936

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Dec 21, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@ruyadorno ruyadorno added fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. and removed fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. dont-land-on-v14.x labels Dec 21, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @ruyadorno. Please 👍 to approve.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2022
@ruyadorno

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48682/

@ruyadorno ruyadorno mentioned this pull request Dec 21, 2022
Closed
@github-actions github-actions bot mentioned this pull request Dec 22, 2022
Open
14 tasks
@siemenstan siemenstan mentioned this pull request Dec 22, 2022
Closed
@richardlau
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/48682/

Node.js 14 CI is currently broken: nodejs/build#3131

This was referenced Dec 23, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 30, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 1, 2023
Open
20 tasks
@ruyadorno
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/48682/

Node.js 14 CI is currently broken: nodejs/build#3131

Is it working again @richardlau ?

@richardlau
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/48682/

Node.js 14 CI is currently broken: nodejs/build#3131

Is it working again @richardlau ?

Unfortunately not. Nobody looked at the failures while I was out and I've only been able to fix the macOS 10.14 builds since I've been back at work.

@ruyadorno ruyadorno mentioned this pull request Jan 12, 2023
Closed
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jan 20, 2023
Open
13 tasks
@bnoordhuis bnoordhuis mentioned this pull request Jan 20, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jan 21, 2023
Open
14 tasks
@lukekarrys lukekarrys mentioned this pull request Jan 21, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jan 22, 2023
Open
13 tasks
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49133/

@github-actions github-actions bot mentioned this pull request Jan 23, 2023
Open
13 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49138/

This was referenced Jan 24, 2023
Open
Open
@richardlau richardlau removed the fast-track PRs that do not need to wait for 48 hours to land. label Feb 8, 2023
richardlau pushed a commit that referenced this pull request Feb 8, 2023
@ruyadorno @richardlau
deps: upgrade npm to 6.14.18
224e93c 
PR-URL: #45936
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@richardlau
Copy link
Member

Landed in 224e93c.

@richardlau richardlau closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruyadorno @nodejs-github-bot @richardlau @RafaelGSS