-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: refactor to use validateFunction
#46007
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221229_validatefunction_stream
Jan 1, 2023
Merged
stream: refactor to use validateFunction
#46007
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221229_validatefunction_stream
Jan 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deokjinkim
force-pushed
the
221229_validatefunction_stream
branch
from
December 29, 2022 04:23
8afc82e
to
58097c5
Compare
VoltrexKeyva
approved these changes
Dec 29, 2022
aduh95
approved these changes
Dec 29, 2022
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Dec 29, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 29, 2022
anonrig
approved these changes
Dec 30, 2022
10 tasks
This was referenced Dec 31, 2022
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 1, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 1, 2023
Landed in 979ec87 |
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
PR-URL: #46007 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
22 tasks
Merged
This was referenced Jan 3, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #46007 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
22 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #46007 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #46007 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
PR-URL: #46007 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
web streams
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.