Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 11.0 #46125

Closed
wants to merge 8 commits into from
Closed

deps: update V8 to 11.0 #46125

wants to merge 8 commits into from

Commits on Jan 30, 2023

  1. deps: update V8 to 11.0.226.12

    @targos
    targos committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    09de414 View commit details
    Browse the repository at this point in the history

  2. build: reset embedder string to "-node.0"

    @targos
    targos committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    49b6e0f View commit details
    Browse the repository at this point in the history

  3. src: update NODE_MODULE_VERSION to 115 

    Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 11.0.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    @targos
    targos committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    fd8c0ad View commit details
    Browse the repository at this point in the history

  4. deps: always define V8_EXPORT_PRIVATE as no-op 

    dllexport introduces issues when compiling with MSVC.
    @targos
    targos committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    4c47427 View commit details
    Browse the repository at this point in the history

  5. deps: silence irrelevant V8 warning 

    PR-URL: nodejs#45579
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @targos
    targos committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    e17583a View commit details
    Browse the repository at this point in the history

  6. deps: V8: cherry-pick 166fd2f38f44 

    Original commit message:

    [cppgc]: Fix build on msvc
    Fixes compilation with msvc 2019 toolchain.

    See: nodejs#37330 (comment)

    Bug: v8:12661
    Change-Id: I7cfd87a3dd531a2e4913d82b743fb8ecdfdb5ed8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3533019
    Reviewed-by: Michael Lippautz <[email protected]>
    Commit-Queue: Michael Lippautz <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#85087}

Refs: v8/v8@166fd2f
    @targos
    targos committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    88f254b View commit details
    Browse the repository at this point in the history

  7. deps: V8: backport 1e4b71d99fea 

    Original commit message:

    [heap] Move the Stack object from ThreadLocalTop to Isolate

    Stack information is thread-specific and, until now, it was stored in a
    field in ThreadLocalTop. This CL moves stack information to the isolate
    and makes sure to update the stack start whenever a main thread enters
    the isolate. At the same time, the Stack object is refactored and
    simplified.

    As a side effect, after removing the Stack object, ThreadLocalTop
    satisfies the std::standard_layout trait; this fixes some issues
    observed with different C++ compilers.

    Bug: v8:13630
    Bug: v8:13257
    Change-Id: I026a35af3bc6999a09b21f277756d4454c086343
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4152476
    Reviewed-by: Michael Lippautz <[email protected]>
    Reviewed-by: Omer Katz <[email protected]>
    Commit-Queue: Nikolaos Papaspyrou <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#85445}

Refs: v8/v8@1e4b71d
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4200636
Co-Authored-By: Nikolaos Papaspyrou <[email protected]>
    @targos @nickie
    targos and nickie committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    ebea4f1 View commit details
    Browse the repository at this point in the history

  8. tools: update V8 gypfiles for 11.0

    @targos
    targos committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    74ba7bc View commit details
    Browse the repository at this point in the history