Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update simdutf to 3.0.0 #46211

Closed
wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of simdutf to 3.0.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jan 14, 2023
@anonrig anonrig self-assigned this Jan 14, 2023
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@gengjiawen
Copy link
Member

Looks like issues still exists.

@anonrig
Copy link
Member

anonrig commented Jan 15, 2023

Looks like issues still exists.

We need to update the existing code to use the functions I’ve added to simdutf. @addaleax can you take a look into this?

@addaleax
Copy link
Member

@anonrig It should just be a matter of dropping the le bit from the function names which we use, right?

@anonrig
Copy link
Member

anonrig commented Jan 16, 2023

@anonrig It should just be a matter of dropping the le bit from the function names which we use, right?

Yes that's correct.

@AdamMajer
Copy link
Contributor

Can we have this code in editable format? The concatenated/generated C++ is not exactly best for applying patches later on, if they are required. From what I can see, this is just running a python script on the original sources?

Sorry to be the squeaky wheel on this stuff.

@anonrig
Copy link
Member

anonrig commented Jan 16, 2023

From what I can see, this is just running a python script on the original sources?

I didn't quite understand what you mean by this but the changes are done in the upstream library (https://github.com/simdutf/simdutf) which has its own distribution strategy. We don't have any internal patches to simdutf.

Due to the breaking change happening on simdutf, we need to fix the breaking change in our repository to update simdutf to 3.0.0.

@anonrig
Copy link
Member

anonrig commented Jan 18, 2023

Closing this in favor of simdutf 3.1.0

@anonrig anonrig closed this Jan 18, 2023
@anonrig anonrig deleted the actions/tools-update-simdutf branch January 18, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants