-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update simdutf to 3.0.0 #46211
Conversation
Looks like issues still exists. |
We need to update the existing code to use the functions I’ve added to simdutf. @addaleax can you take a look into this? |
@anonrig It should just be a matter of dropping the |
Yes that's correct. |
Can we have this code in editable format? The concatenated/generated C++ is not exactly best for applying patches later on, if they are required. From what I can see, this is just running a python script on the original sources? Sorry to be the squeaky wheel on this stuff. |
I didn't quite understand what you mean by this but the changes are done in the upstream library (https://github.com/simdutf/simdutf) which has its own distribution strategy. We don't have any internal patches to simdutf. Due to the breaking change happening on simdutf, we need to fix the breaking change in our repository to update simdutf to 3.0.0. |
Closing this in favor of simdutf 3.1.0 |
This is an automated update of simdutf to 3.0.0.