wasi: add wasi sock_accept stub #46434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
mhdawson
removed
the
wasi
mhdawson
force-pushed
the
wasi-sockets2
branch
from
6f3a82a
to
e6d345b
Compare
mhdawson
added
the
wasi
mhdawson
force-pushed
the
wasi-sockets2
branch
from
e6d345b
to
16fbfbe
Compare
jasnell
approved these changes
Jan 31, 2023
cjihrig
approved these changes
Jan 31, 2023
mhdawson
commented
Jan 31, 2023
|
Pushed commit to address all comment so far. |
|
As mentioned needs an updated version of uvwasi before tests will pass. |
Signed-off-by: Michael Dawson <[email protected]>
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]>
mhdawson
force-pushed
the
wasi-sockets2
branch
from
318cf2f
to
5e2de27
Compare
|
Just added commit to update uvwasi to v0.0.16 so that tests can pass. @cjihrig a re-LGTM from you might make sense due to that addition. |
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Feb 23, 2023
mhdawson
added a commit
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
mhdawson
added a commit
that referenced
this pull request
Mar 1, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 8e4fa26...bd04106 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
@mhdawson this didn't land cleanly on v18.x-staging. Do you mind opening a backport PR to v18.x? Thank you |
danielleadams
added
the
backport-requested-v18.x
|
@danielleadams thanks for the head up. Will add it to my list of things. |
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Apr 6, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Apr 6, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#46434 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
@danielleadams PR for backport - #47455 |
mhdawson
added
backported-to-v18.x
danielleadams
pushed a commit
that referenced
this pull request
May 29, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Backport-PR-URL: #47455 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
May 29, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Backport-PR-URL: #47455 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/uvwasi#185
Add stub for sock_accept so that we have stubs
for all of the sock methods in wasi_snapshot_preview1.
Its a bit awkward as the method was added after the
initial definitial of wasi_snapshot-preview1 but I
think it should be semver minor at most to add
the method.
Depends on nodejs/uvwasi#185
being landed in uvwasi first and an updated version
of uvwasi that includes that being pulled into
Node.js
Signed-off-by: Michael Dawson [email protected]