Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update gpg key for Myles Borins #4657

Closed
wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

Original key did not have personal information associated with it.

The new key rectifies this problem

Original key did not have personal information associated with it.

The new key rectifies this problem
@MylesBorins MylesBorins added the doc Issues and PRs related to the documentations. label Jan 13, 2016
@MylesBorins
Copy link
Contributor Author

/cc @jasnell @rvagg @Fishrock123

@cjihrig
Copy link
Contributor

cjihrig commented Jan 13, 2016

LGTM

@rvagg
Copy link
Member

rvagg commented Jan 13, 2016

gpg: requesting key CC11F4C8 from hkp server pool.sks-keyservers.net
gpg: DBG: armor-keys-failed (KEY 0xC4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 BEGIN
) ->0
gpg: DBG: armor-keys-failed (KEY 0xC4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 END
) ->0
gpg: key CC11F4C8: public key "Myles Borins <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)

I believe these errors are just debug messages https://bugs.gnupg.org/gnupg/issue1934, I can't test this on my Linux machine atm so this is just OSX. Does anyone else get odd messages when importing the new key?

@cjihrig
Copy link
Contributor

cjihrig commented Jan 13, 2016

@rvagg I saw similar error messages importing @thealphanerd and @evanlucas keys when they joined the release team.

EDIT: Also:

gpg: requesting key 7D83545D from hkp server pool.sks-keyservers.net
gpg: DBG: armor-keys-failed (KEY 0xDD8F2338BAE7501E3DD5AC78C273792F7D83545D BEGIN
) ->0
gpg: DBG: armor-keys-failed (KEY 0xDD8F2338BAE7501E3DD5AC78C273792F7D83545D END
) ->0
gpg: key 7D83545D: public key "Rod Vagg <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)

@rvagg
Copy link
Member

rvagg commented Jan 13, 2016

ok .. well it imported, so lgtm I suppose

@jasnell
Copy link
Member

jasnell commented Jan 13, 2016

LGTM

jasnell pushed a commit that referenced this pull request Jan 13, 2016
Original key did not have personal information associated with it.

The new key rectifies this problem

PR-URL: #4657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 13, 2016

Landed in 287325c

@jasnell jasnell closed this Jan 13, 2016
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
Original key did not have personal information associated with it.

The new key rectifies this problem

PR-URL: #4657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Starefossen pushed a commit to Starefossen/docker-node that referenced this pull request Jan 13, 2016
PR-URL: nodejs#85

Related: nodejs/node#4657

Signed-off-by: Hans Kristian Flaatten <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
Original key did not have personal information associated with it.

The new key rectifies this problem

PR-URL: #4657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Jan 14, 2016
Original key did not have personal information associated with it.

The new key rectifies this problem

PR-URL: #4657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
Original key did not have personal information associated with it.

The new key rectifies this problem

PR-URL: #4657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis
Copy link
Member

Should there perhaps be some kind of audit trail in the docs to help users understand why Myles' key changed between releases? It's going to be confusing now when they download an older binary or tarball.

@MylesBorins
Copy link
Contributor Author

@bnoordhuis v5.4.1 was signed by @Fishrock123 to avoid that exact case. My prior key was never used

MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Original key did not have personal information associated with it.

The new key rectifies this problem

PR-URL: #4657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
@MylesBorins MylesBorins deleted the update-myles-gpg branch January 21, 2016 22:59
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Original key did not have personal information associated with it.

The new key rectifies this problem

PR-URL: nodejs#4657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants