Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: implement register utility #46826

Merged
merged 15 commits into from
Jun 12, 2023
Merged

module: implement register utility #46826

merged 15 commits into from
Jun 12, 2023
+490 −10

Commits on Jun 10, 2023

  1. module: implement register utility

    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    65111a2 View commit details
    Browse the repository at this point in the history

  2. loaders: support URL in register fn 

    Support loaders to be registered as `URL` instance in `register`
fn.
    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    29d153e View commit details
    Browse the repository at this point in the history

  3. loaders: add parentURL as second parameter 

    Add `parentURL` as second parameter of `register` fn so user can
decide from where his loader path or package name will be resolved.
    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    6e43af3 View commit details
    Browse the repository at this point in the history

  4. chore: de-lint (add trailing comma)

    @JakobJingleheimer @jlenon7
    JakobJingleheimer authored and jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    b351260 View commit details
    Browse the repository at this point in the history

  5. ASCII order

    @aduh95 @jlenon7
    aduh95 authored and jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    4a0e047 View commit details
    Browse the repository at this point in the history

  6. loaders,fix: use URLs instead of paths 

    Use URLs instead of paths to avoid problems in Windows CI.
    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    418d568 View commit details
    Browse the repository at this point in the history

  7. fix: linting 

    Remove unused modules.
    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    c2104d3 View commit details
    Browse the repository at this point in the history

  8. test: use URL instances for file test case 

    As mentioned by @aduh95, all tests in
`test-esm-loader-programmatically.mjs` are using string literals as
arguments for `register` fn. Start using URL instances for file test
case.
    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    5400a6e View commit details
    Browse the repository at this point in the history

  9. fix,test: use right loaders and export it properly 

    Use right loaders in `node_modules` and export them properly.
    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    d3a1a81 View commit details
    Browse the repository at this point in the history

  10. test: export modules from node_modules 

    Export modules from `node_modules` in our loaders.
    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    9e83305 View commit details
    Browse the repository at this point in the history

  11. fix,test: move real implementation of loaders 

    Move the implementation of `loader-load-passthru.mjs` and from
`loader-resolve-passthru.mjs` to it's own file and export it in
`node_modules`.
    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    e485f99 View commit details
    Browse the repository at this point in the history

  12. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @jlenon7 @aduh95
    jlenon7 and aduh95 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    1ee3823 View commit details
    Browse the repository at this point in the history

  13. Update lib/internal/modules/esm/loader.js 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @jlenon7 @aduh95
    jlenon7 and aduh95 authored Jun 10, 2023
    Configuration menu
    Copy the full SHA
    0db88d8 View commit details
    Browse the repository at this point in the history

  14. fix: remove getCwdSafe fn 

    The `getCwdSafe` fn it's no longer related to this PR, so we are
going to create its own PR to address it.
    @jlenon7
    jlenon7 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    cd47b14 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @jlenon7 @aduh95
    jlenon7 and aduh95 authored Jun 11, 2023
    Configuration menu
    Copy the full SHA
    27f8ac7 View commit details
    Browse the repository at this point in the history