Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move socket from CWD to temporary directory #46863

Merged
merged 1 commit into from
Mar 1, 2023
Merged

test: move socket from CWD to temporary directory #46863

merged 1 commit into from
Mar 1, 2023

Conversation

LiviaMedeiros
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 27, 2023
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50066/

@github-actions github-actions bot mentioned this pull request Feb 28, 2023
Open
16 tasks
@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 28, 2023
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Open
15 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit b509e01 into nodejs:main Mar 1, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b509e01

@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Open
15 tasks
targos pushed a commit that referenced this pull request Mar 13, 2023
@LiviaMedeiros @targos
test: move socket from CWD to temporary directory
f1ac88a 
PR-URL: #46863
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@LiviaMedeiros @targos
test: move socket from CWD to temporary directory
6fa142d 
PR-URL: #46863
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@LiviaMedeiros @danielleadams
test: move socket from CWD to temporary directory
b344e74 
PR-URL: #46863
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiviaMedeiros @nodejs-github-bot @lpinca @aduh95