Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTS: backport no-unused-vars to v4.x-staging #4688

Merged
merged 11 commits into from
Jan 14, 2016
Merged

LTS: backport no-unused-vars to v4.x-staging #4688

merged 11 commits into from
Jan 14, 2016

Commits on Jan 14, 2016

  1. test: remove unused modules 

    Many tests use require() to import modules that subsequently never gets
used. This removes those imports and, in a few cases, removes other
unused variables from tests.

PR-URL: nodejs#4684
Reviewed-By: Myles Borins <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    dba3dc5 View commit details
    Browse the repository at this point in the history

  2. lib: remove unused modules 

    Some files in `lib` were using `require` to load modules that were
subsequently not used in the file. This removes those `require`
statements.

PR-URL: nodejs#4683
Reviewed-By: Myles Borins <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    46e3fd6 View commit details
    Browse the repository at this point in the history

  3. test: remove unused vars 

    Remove unused vars in tests

PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    7894f19 View commit details
    Browse the repository at this point in the history

  4. test: remove unused vars in ChildProcess tests 

    In addition to removing unused vars, this also fixes an instance where
booleans were set presumably to check something but then never used.
This now confirms that the events that were setting the booleans are
fired.

PR-URL: nodejs#4425
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    e36811b View commit details
    Browse the repository at this point in the history

  5. test: remove unused variables from net tests 

    Remove a handful of variables that are declared but never used in the
tests for the net module.

PR-URL: nodejs#4430
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    8c094be View commit details
    Browse the repository at this point in the history

  6. test: remove unused variables from HTTPS tests 

    PR-URL: nodejs#4426
Reviewed-By: Johan Bergström <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    ba1847d View commit details
    Browse the repository at this point in the history

  7. test: remove unused variables from TLS tests 

    Some of the TLS tests have variables that do not get used. This removes
those variables.

PR-URL: nodejs#4424
Reviewed-By: Johan Bergström <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    7c30944 View commit details
    Browse the repository at this point in the history

  8. test: extend timeout in Debug mode 

    Debug mode slows execution speed. There is work afoot to enable Debug
mode runs on the continuous integration infrastructure for the project.
Some tests are timing out, such as test-net-nodejsGH-5504.js.

This change doubles the timeout returned from `common.platformTimeout()`
when running in Debug mode. It also removes an unused variable from the
aforementioned test-net-nodejsGH-5504.js.

PR-URL: nodejs#4431
Reviewed-By: Johan Bergström <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    36d28ce View commit details
    Browse the repository at this point in the history

  9. test: remove unused variables form http tests 

    The http tests seem especially prone to including unused variables.
This change removes them.

PR-URL: nodejs#4422
Reviewed-By: Johan Bergström <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    eb53af2 View commit details
    Browse the repository at this point in the history

  10. test: remove unused vars from parallel tests 

    Remove all remaining unused variables from tests in test/parallel.

PR-URL: nodejs#4511
Reviewed-By: James M Snell<[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    b3b150c View commit details
    Browse the repository at this point in the history

  11. tools: implement no-unused-vars for eslint 

    PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @Trott
    Trott authored and Myles Borins committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    ef5e9ef View commit details
    Browse the repository at this point in the history