Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: improve primordials typings #46970

Merged
merged 1 commit into from
Mar 8, 2023
Merged

typings: improve primordials typings #46970

merged 1 commit into from
Mar 8, 2023
+27 −3

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 6, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. typings labels Mar 6, 2023
MoLow
MoLow approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50224/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0c46051 into nodejs:main Mar 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 0c46051

@aduh95 aduh95 deleted the primordials-typings branch March 8, 2023 10:49
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
typings: improve primordials typings
525a2db 
PR-URL: #46970
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@aduh95 @targos
typings: improve primordials typings
63a83b4 
PR-URL: #46970
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
typings: improve primordials typings
78b79c0 
PR-URL: #46970
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @anonrig @MoLow