Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: automate cares update #46993

Merged

Conversation

marco-ippolito
Copy link
Member

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 7, 2023
@aduh95
Copy link
Contributor

aduh95 commented Mar 7, 2023

Would you be interested in doing something similar to what was done in #46488 by @tony-go? If not, no problem, it can be done in a follow-up PR.

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Mar 7, 2023

Would you be interested in doing something similar to what was done in #46488 by @tony-go? If not, no problem, it can be done in a follow-up PR.

yes! I moved cares to the new folder, will update it like in the pr you linked.
I'll open a new pr to update all other scripts.

Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Richard Lau <[email protected]>
tools/dep_updaters/update-cares.sh Outdated Show resolved Hide resolved
tools/dep_updaters/update-cares.sh Outdated Show resolved Hide resolved
tools/dep_updaters/update-cares.sh Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <[email protected]>
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 9, 2023
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3591728 into nodejs:main Mar 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 3591728

targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46993
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46993
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46993
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants