Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix lint error #47007

Closed
wants to merge 1 commit into from
Closed

src: fix lint error #47007

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Mar 8, 2023

a lint error was introduced here e5933c8

@MoLow MoLow requested a review from joyeecheung March 8, 2023 00:43
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 8, 2023
@MoLow MoLow mentioned this pull request Mar 8, 2023
Closed
@MoLow MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 8, 2023
@MoLow
Copy link
Member Author

MoLow commented Mar 8, 2023

closing in favor of #47007

@MoLow MoLow closed this Mar 8, 2023
@MoLow MoLow deleted the fix-cpp-lint branch March 8, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoLow @nodejs-github-bot