Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: rename the startup performance initiative to startup snapshot #47111

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

joyeecheung
Copy link
Member

The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot".

Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.

The initiative has been more focused on startup snapshot integration
which is more of a feature on its own, so rename it to "startup
snapshot".

Background: we are also considering adding a more generic performance
initiative in nodejs/TSC#1343.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 15, 2023
@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 17, 2023
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 30d92e8 into nodejs:main Mar 17, 2023
targos pushed a commit that referenced this pull request Mar 18, 2023
…47111)

The initiative has been more focused on startup snapshot integration
which is more of a feature on its own, so rename it to "startup
snapshot".

Background: we are also considering adding a more generic performance
initiative in nodejs/TSC#1343.
@targos
Copy link
Member

targos commented Mar 18, 2023

This was landed without commit metadata, but that happened 13 hours ago and 2 other commits were landed on top of it. I don't know if we can still force-push...

@legendecas
Copy link
Member

@targos can we enable GitHub's "Require status checks to pass before merging" and post a required status report that never passes to block the "merge" button? This still allows node-core-util to land commits since it pushes to the main branch directly.

@targos
Copy link
Member

targos commented Mar 20, 2023

Not really. The commit queue uses the "squash and merge" button (with a GitHub API call)

@targos
Copy link
Member

targos commented Mar 20, 2023

Also, if you require status checks to pass before merging, it becomes impossible to push a commit directly, as it wouldn't have the required check.

@legendecas
Copy link
Member

good to know that. thanks for the explanation!

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
…47111)

The initiative has been more focused on startup snapshot integration
which is more of a feature on its own, so rename it to "startup
snapshot".

Background: we are also considering adding a more generic performance
initiative in nodejs/TSC#1343.
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
…47111)

The initiative has been more focused on startup snapshot integration
which is more of a feature on its own, so rename it to "startup
snapshot".

Background: we are also considering adding a more generic performance
initiative in nodejs/TSC#1343.
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
…47111)

The initiative has been more focused on startup snapshot integration
which is more of a feature on its own, so rename it to "startup
snapshot".

Background: we are also considering adding a more generic performance
initiative in nodejs/TSC#1343.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.