Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix grammar in the collaborator guide #47245

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

VoltrexKeyva
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 24, 2023
@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 24, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@VoltrexKeyva VoltrexKeyva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2023
@VoltrexKeyva VoltrexKeyva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 545b594 into nodejs:main Mar 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 545b594

@VoltrexKeyva VoltrexKeyva deleted the fix-grammar branch March 24, 2023 13:32
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
PR-URL: #47245
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
PR-URL: #47245
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
PR-URL: #47245
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47245
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants