Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run doctool tests in parallel #47273

Closed
wants to merge 1 commit into from
Closed

test: run doctool tests in parallel #47273

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Mar 27, 2023 •
edited
Loading

I don't see why we can't run doctool tests and wpt in parallel, so make them run in parallel.

About other non-parallel tests:

  • benchmark: needs some refactoring in net and tls benchmarks to stop using common.PORT
  • embedding: there is only one test, so making it run in parallel doesn't add much
  • internet: needs refactoring to stop using common.PORT
  • known-issues: usually not run anyway
  • tick-processor: this does not even work locally for me?
  • pummel: takes a long time to run anyway, which is its point, and I am not sure if it can actually be run in parallel

Refs: #47146

EDIT: removed the WPT changes in favor of #47283

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Mar 27, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50632/

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2023
targos
targos approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer us to make the WPT runner itself spawn parallel workers, but this change is good for now.

@panva

This comment was marked as resolved.

Sign in to view
@panva panva mentioned this pull request Mar 28, 2023
Merged
@panva panva added the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2023
@panva
Copy link
Member

panva commented Mar 30, 2023

Adding blocked PRs that are blocked by other issues or PRs. until I resolve an issue with the WPT Runner writing WPT Report. It is not currently set up to handle parallel execution. Shouldn't take long to unblock.

@joyeecheung
Copy link
Member Author

I can also just remove the WPT changes

@joyeecheung joyeecheung removed the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2023
@joyeecheung joyeecheung changed the title test: run doctool tests and wpt tests in parallel test: run doctool tests in parallel Mar 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50702/

@panva
Copy link
Member

panva commented Mar 30, 2023

Ok, i'll re-add them to #47283

@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Open
34 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50749/

@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Open
38 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50776/

This was referenced Apr 2, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50874/

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
@joyeecheung
Copy link
Member Author

Landed in cd36f6e

@joyeecheung joyeecheung closed this Apr 4, 2023
@joyeecheung joyeecheung removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
joyeecheung added a commit that referenced this pull request Apr 4, 2023
@joyeecheung
test: run doctool tests in parallel
cd36f6e 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@joyeecheung @RafaelGSS
test: run doctool tests in parallel
dda052a 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@joyeecheung @RafaelGSS
test: run doctool tests in parallel
627e339 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@joyeecheung @RafaelGSS
test: run doctool tests in parallel
032ea70 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@joyeecheung @RafaelGSS
test: run doctool tests in parallel
94bc64c 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@joyeecheung @RafaelGSS
test: run doctool tests in parallel
130420b 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@joyeecheung @RafaelGSS
test: run doctool tests in parallel
2356e10 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@joyeecheung @danielleadams
test: run doctool tests in parallel
397881a 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@joyeecheung @MoLow
test: run doctool tests in parallel
3c157cb 
PR-URL: nodejs#47273
Refs: nodejs#47146
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@joyeecheung @nodejs-github-bot @panva @jasnell @Trott @anonrig @targos @cjihrig @debadree25