[v19.x backport] deps: V8: cherry-pick cb30b8e17429 #47307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
targos
approved these changes
Mar 30, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
gengjiawen
approved these changes
Mar 30, 2023
RaisinTen
added
the
author ready
richardlau
approved these changes
Mar 30, 2023
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Mar 30, 2023
34 tasks
This comment was marked as outdated.
This comment was marked as outdated.
|
I just landed V8 11.3 on main and it contains this fix. You might want to backport to v19.x-staging instead. |
jasnell
approved these changes
Mar 31, 2023
38 tasks
RaisinTen
changed the title
Original commit message:
Fix compilation error in platform.h for ASAN
The last two operands of the conditional expression needs to be
of the same type to compile.
Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802
Commit-Queue: Joyee Cheung <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86235}
Refs: v8/v8@cb30b8e
Refs: nodejs#43370
Signed-off-by: Darshan Sen <[email protected]>
RaisinTen
force-pushed
the
fix-compilation-error-in-platform.h-for-ASAN
branch
from
995715a
to
97f9fbc
Compare
|
@targos done, could you PTAL? |
RaisinTen
changed the title
RaisinTen
removed
the
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
targos
approved these changes
Apr 3, 2023
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
29 tasks
|
@targos it seems like the only remaining CI failure on this PR is coming from https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5269/: Testing hash seed
export PATH="/usr/bin:/home/iojs/build/workspace/node-test-commit-v8-linux/depot_tools:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" && \
/usr/bin/python3.9 deps/v8/tools/run-tests.py --gn --arch=ppc64 --progress=dots --timeout=120 intl \
mjsunit cctest debugger inspector message preparser \
--json-test-results /home/iojs/build/workspace/node-test-commit-v8-linux/v8-tap.json --slow-tests-cutoff 1000000
Traceback (most recent call last):
File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/run-tests.py", line 11, in <module>
from testrunner import standard_runner
File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/standard_runner.py", line 16, in <module>
from testrunner.testproc.progress import ResultsTracker, ProgressProc
File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/testproc/progress.py", line 9, in <module>
from testrunner.testproc.resultdb import ResultDBIndicator
File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/testproc/resultdb.py", line 8, in <module>
import requests
ModuleNotFoundError: No module named 'requests'
make: *** [Makefile:713: test-v8] Error 1
Build step 'Execute shell' marked build as failure
Sending e-mails to: michael_dawson@ca.ibm.com vieuxtech@gmail.com info@bnoordhuis.nl
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?
Collecting metadata...
Metadata collection done.
Notifying upstream projects of job completion
Finished: FAILUREwhich looks totally unrelated. Is this a known issue on v19.x-staging? Should we land this PR manually irrespective of that failure? |
|
Yes, it's a known issue fixed by #47239 |
26 tasks
RaisinTen
added a commit
that referenced
this pull request
Apr 5, 2023
Original commit message:
Fix compilation error in platform.h for ASAN
The last two operands of the conditional expression needs to be
of the same type to compile.
Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802
Commit-Queue: Joyee Cheung <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86235}
Refs: v8/v8@cb30b8e
Refs: #43370
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47307
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
|
Landed in 5ddd1c9 |
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Original commit message:
Fix compilation error in platform.h for ASAN
The last two operands of the conditional expression needs to be
of the same type to compile.
Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802
Commit-Queue: Joyee Cheung <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86235}
Refs: v8/v8@cb30b8e
Refs: #43370
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47307
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@cb30b8e
Refs: #43370