Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: refactor configure.py #47323

Closed
wants to merge 1 commit into from

Commits on Apr 16, 2023

  1. build: refactor configure.py

    - Explicitly specify the encoding when opening files.
    - Use f-strings to format strings.
    - Use `isinstance()` for type checks instead of `type()`.
    - Use the `with` keyword for resource-allocating operations.
    - Avoid using multiple statements in a single line.
    - Remove unnecessary `else` clauses after `return`.
    - Iterate with the `items()` method of dictionaries when both the key
    and value are used.
    - Remove unnecessary parentheses.
    - Rename unused unpacked variables to `_`, `_1`, etc etc.
    - Rename the `list` variable to avoid conflict with the global
    `list()` function.
    - Remove unused `path` parameter of the `icu_download()` function.
    - Use the `pathlib` library for paths instead of `os.path`.
    VoltrexKeyva committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    68ef467 View commit details
    Browse the repository at this point in the history