Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: automate cjs-module-lexer dependency update #47446

Conversation

marco-ippolito
Copy link
Member

Refs: nodejs/security-wg#828
@nodejs/security-wg

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Apr 6, 2023
@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2023
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

label: dependencies
run: |
./tools/dep_updaters/update-cjs-module-lexer.sh > temp-output
cat temp-output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but I can't really say if you left this while debugging or it's actually needed. Just pointing this out for you to double check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debugging purposes we use it in every job

@richardlau
Copy link
Member

The script is missing this step to update the esm docs:

* Update the link to the cjs-module-lexer in the list at the end of
[doc/api/esm.md](../api/esm.md)
to point to the updated version.

@richardlau
Copy link
Member

cc @guybedford

@marco-ippolito marco-ippolito force-pushed the feat/automate-cjs-module-lexer-update branch from 1f9a35c to bf1e623 Compare April 8, 2023 10:03
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2023
@nodejs-github-bot nodejs-github-bot merged commit cfb654c into nodejs:main Apr 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in cfb654c

RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
PR-URL: #47446
Refs: nodejs/security-wg#828
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
tniessen added a commit to tniessen/node that referenced this pull request Apr 24, 2023
nodejs-github-bot pushed a commit that referenced this pull request Apr 24, 2023
Refs: #47446
PR-URL: #47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
Refs: nodejs#47446
PR-URL: nodejs#47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
Refs: nodejs#47446
PR-URL: nodejs#47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
Refs: nodejs#47446
PR-URL: nodejs#47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
targos pushed a commit that referenced this pull request May 2, 2023
Refs: #47446
PR-URL: #47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47446
Refs: nodejs/security-wg#828
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Refs: #47446
PR-URL: #47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47446
Refs: nodejs/security-wg#828
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Refs: nodejs#47446
PR-URL: nodejs#47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants