-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: automate cjs-module-lexer dependency update #47446
tools: automate cjs-module-lexer dependency update #47446
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
label: dependencies | ||
run: | | ||
./tools/dep_updaters/update-cjs-module-lexer.sh > temp-output | ||
cat temp-output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but I can't really say if you left this while debugging or it's actually needed. Just pointing this out for you to double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for debugging purposes we use it in every job
The script is missing this step to update the esm docs: node/doc/contributing/maintaining-cjs-module-lexer.md Lines 47 to 49 in 0c76922
|
cc @guybedford |
1f9a35c
to
bf1e623
Compare
Landed in cfb654c |
PR-URL: #47446 Refs: nodejs/security-wg#828 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refs: #47446 PR-URL: #47701 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Refs: nodejs#47446 PR-URL: nodejs#47701 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Refs: nodejs#47446 PR-URL: nodejs#47701 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Refs: nodejs#47446 PR-URL: nodejs#47701 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Refs: #47446 PR-URL: #47701 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
PR-URL: #47446 Refs: nodejs/security-wg#828 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refs: #47446 PR-URL: #47701 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
PR-URL: nodejs#47446 Refs: nodejs/security-wg#828 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refs: nodejs#47446 PR-URL: nodejs#47701 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Refs: nodejs/security-wg#828
@nodejs/security-wg