Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] test: fix test-net-happy-eyeballs without IPv6 support #47447

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] test: fix test-net-happy-eyeballs without IPv6 support #47447

wants to merge 1 commit into from

Conversation

LiviaMedeiros
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Apr 6, 2023
@LiviaMedeiros LiviaMedeiros mentioned this pull request Apr 6, 2023
Merged
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51840/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51841/

This was referenced May 18, 2023
Open
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51990/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51996/

This was referenced May 30, 2023
Open
Open
Open
Open
Open
@ruyadorno
Copy link
Member

@LiviaMedeiros this PR needs rebasing

@LiviaMedeiros
test: fix test-net-autoselectfamily for kernel without IPv6 support
15b1c5a 
PR-URL: nodejs#45856
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
@LiviaMedeiros
Copy link
Contributor Author

Now that #49016 has landed, #45856 should be pickable as is.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiviaMedeiros @nodejs-github-bot @ruyadorno