tools: automate v8 patch update #47594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
meta
mscdex
reviewed
Apr 17, 2023
|
Did you consider using the |
|
@targos I basically copied what |
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
03b4a51
to
f8da622
Compare
|
I have created a separate action to update v8, caching the |
ShogunPanda
approved these changes
Apr 21, 2023
targos
requested changes
Apr 21, 2023
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
f912fa3
to
0a46fe1
Compare
targos
reviewed
Apr 24, 2023
Co-authored-by: Michaël Zasso <[email protected]>
|
sorry for changing my mind a few times but due to the amount of dependencies I've decided to move it back to |
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
97e3b47
to
936482c
Compare
targos
reviewed
Apr 24, 2023
targos
reviewed
Apr 24, 2023
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
d115ed1
to
a7c237c
Compare
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
a7c237c
to
9e5b634
Compare
targos
reviewed
Apr 24, 2023
marco-ippolito
commented
Apr 24, 2023
targos
approved these changes
Apr 24, 2023
UlisesGascon
approved these changes
Apr 25, 2023
marco-ippolito
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 71a776b |
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 29, 2023
PR-URL: nodejs#47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#828
please review carefully, first time approaching v8
if you know a way of creating a patch without cloning v8 (which is very expensive) that would be great
@nodejs/security-wg