Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: put is_building_snapshot state in IsolateData and introduce ERR_NOT_SUPPORTED_IN_SNAPSHOT #47887

Closed
wants to merge 3 commits into from

Commits on May 5, 2023

  1. bootstrap: put is_building_snapshot state in IsolateData

    Previously we modify the CLI options store to indicate whether the
    isolate is created for building snapshot, which is a bit hacky and
    makes it difficult to tell whether the snapshot is built from the
    command line or through other APIs. This patch adds
    is_building_snapshot to IsolateData and use this instead when we
    need to know whether the isolate is created for building snapshot
    (but do not care about where that request is coming from).
    joyeecheung committed May 5, 2023
    Configuration menu
    Copy the full SHA
    c0ca0f8 View commit details
    Browse the repository at this point in the history
  2. bootstrap: throw ERR_NOT_SUPPORTED_IN_SNAPSHOT in unsupported operation

    This patch adds a new ERR_NOT_SUPPORTED_IN_SNAPSHOT error and throw
    it in the worker constructor.
    joyeecheung committed May 5, 2023
    Configuration menu
    Copy the full SHA
    368a793 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. fixup! bootstrap: throw ERR_NOT_SUPPORTED_IN_SNAPSHOT in unsupported …

    …operation
    
    Co-authored-by: Anna Henningsen <[email protected]>
    joyeecheung and addaleax authored May 6, 2023
    Configuration menu
    Copy the full SHA
    87ca62d View commit details
    Browse the repository at this point in the history