Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: fix typo in endpoint.h #47911

Merged
merged 1 commit into from
May 8, 2023
Merged

quic: fix typo in endpoint.h #47911

merged 1 commit into from
May 8, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented May 7, 2023

No description provided.

@tniessen tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. request-ci Add this label to start a Jenkins CI on a PR. labels May 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Fast-track has been requested by @tniessen. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Jiralite
Copy link

Jiralite commented May 8, 2023

Whilst this is being fast-tracked, there are other typos in this directory:

"intial":

node/src/quic/endpoint.cc

Line 719 in 2545019

// // For client sessions, we always generate a random intial CID for the

"exract":

node/src/quic/sessionticket.h

Line 63 in 2545019

// metadata in the session ticket when it is created, and the exract and

A lot more typos can be found using https://crates.io/crates/typos-cli, enjoy!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51694/

@tniessen
Copy link
Member Author

tniessen commented May 8, 2023

I don't want to interfere with James' progress on QUIC, so I don't intend to fix something as trivial as typos across QUIC. This is just one that I came across in a comment that seems like it might be here to stay :)

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0b3fcfc into nodejs:main May 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 0b3fcfc

This was referenced May 9, 2023
Open
Open
Open
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label May 12, 2023
This was referenced May 13, 2023
Open
Open
@ruyadorno ruyadorno added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Aug 29, 2023
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@MoLow MoLow MoLow approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tniessen @nodejs-github-bot @Jiralite @anonrig @deokjinkim @MoLow @RaisinTen @ruyadorno @targos