-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permission: remove unused function declaration #47957
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:230511_permission_remove_restrictaccess
May 15, 2023
Merged
permission: remove unused function declaration #47957
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:230511_permission_remove_restrictaccess
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
May 11, 2023
RestrictAccess() is declared, but it's not used.
deokjinkim
force-pushed
the
230511_permission_remove_restrictaccess
branch
from
May 11, 2023 08:32
a26a348
to
5befef2
Compare
tniessen
approved these changes
May 11, 2023
cjihrig
approved these changes
May 11, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 11, 2023
anonrig
approved these changes
May 11, 2023
RafaelGSS
approved these changes
May 11, 2023
RafaelGSS
approved these changes
May 11, 2023
23 tasks
deokjinkim
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 12, 2023
RaisinTen
approved these changes
May 12, 2023
lpinca
approved these changes
May 12, 2023
20 tasks
XadillaX
approved these changes
May 13, 2023
14 tasks
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 14, 2023
17 tasks
deokjinkim
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 15, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 15, 2023
Landed in 8cbc307 |
targos
pushed a commit
that referenced
this pull request
May 15, 2023
RestrictAccess() is declared, but it's not used. PR-URL: #47957 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
This was referenced May 16, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
RestrictAccess() is declared, but it's not used. PR-URL: #47957 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
RestrictAccess() is declared, but it's not used. PR-URL: nodejs#47957 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestrictAccess() is declared, but it's not used.