Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set v8_enable_webassembly=false when lite mode is enabled #48248

Merged
merged 1 commit into from
Jun 1, 2023
Merged

build: set v8_enable_webassembly=false when lite mode is enabled #48248

merged 1 commit into from
Jun 1, 2023

Commits on May 30, 2023

  1. build: set v8_enable_webassembly=false when lite mode is enabled 

    We should set v8_enable_webassembly=false when lite mode is enabled,
since v8_enable_lite_mode implies v8_jitless, and wasm currently
doesn't work with jitless. This is automatically handled in gn, but
seems to be not the case in gyp. Enabling lite mode without setting
v8_enable_webassembly=false leads to "Warning: disabling flag
--expose_wasm due to conflicting flags" at runtime.
    @TerrorJack
    TerrorJack committed May 30, 2023
    Configuration menu
    Copy the full SHA
    651489f View commit details
    Browse the repository at this point in the history