Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: fix address iteration with autoSelectFamily #48258

Merged
merged 1 commit into from
Jun 1, 2023
Merged

net: fix address iteration with autoSelectFamily #48258

merged 1 commit into from
Jun 1, 2023

Conversation

indutny
Copy link
Member

@indutny indutny commented May 30, 2023

When autoSelectFamily is set to true, net.connect is supposed to try connecting to both IPv4 and IPv6, interleaving the address types. Instead, it appears that the array that holds the addresses in the order they should be attempted was never used after being populated.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@indutny
Copy link
Member Author

indutny commented May 30, 2023

cc @nodejs/net

(I'd appreciate a backport to 18)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels May 30, 2023
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2023
@juanarbol
Copy link
Member

I could try backporting to v18 when this lands.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52011/

@ShogunPanda
Copy link
Contributor

OMG!
Nice spot, thanks for finding it. You are absolutely right!

@ShogunPanda
Copy link
Contributor

I'm gonna ask to fast track this, it might be also be used in #48189.

@ShogunPanda ShogunPanda added the fast-track PRs that do not need to wait for 48 hours to land. label May 31, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @ShogunPanda. Please 👍 to approve.

tniessen
tniessen approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, that, along with #48145, is a significant deviation from the RFC, and yet it's enabled by default. Is there any way to add a test for this to avoid this in the future?

@ShogunPanda
Copy link
Contributor

@tniessen Yes, we can simulate bunch of addresses returned in order (like A, A, A, A, AAAA, AAAA, AAAA) and then we can verify we test them alternatively.

@indutny Can you please write such a test?

@indutny
net: fix address iteration with autoSelectFamily
71fe736 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.
@indutny
Copy link
Member Author

indutny commented May 31, 2023

Good idea! @ShogunPanda would something like this suffice?

@ShogunPanda
Copy link
Contributor

ShogunPanda commented May 31, 2023 •
edited
Loading

Yes, that's exactly what I was thinking about, thanks!

@tniessen Are we good on merging this now?

@tniessen
Copy link
Member

@ShogunPanda Modulo approvals and CI, sure :)

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52027/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52034/

@juanarbol juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label May 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 31, 2023
@juanarbol juanarbol added the backport-open-v18.x Indicate that the PR has an open backport. label May 31, 2023
@ShogunPanda ShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 1, 2023
@ShogunPanda ShogunPanda mentioned this pull request Jun 1, 2023
Merged
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit 403a72f into nodejs:main Jun 1, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 403a72f

This was referenced Jun 2, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request Jun 4, 2023
@indutny @targos
net: fix address iteration with autoSelectFamily
950185b 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: #48258
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
Merged
This was referenced Jun 5, 2023
Open
Open
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jun 7, 2023
@indutny @juanarbol
net: fix address iteration with autoSelectFamily
4a90fbd 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jun 7, 2023
@indutny @juanarbol
net: fix address iteration with autoSelectFamily
2d6a8c6 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Backport-PR-URL: nodejs#48275
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
franciszek-koltuniuk-red pushed a commit to franciszek-koltuniuk-red/node that referenced this pull request Jun 7, 2023
@indutny @franciszek-koltuniuk-red
net: fix address iteration with autoSelectFamily
cd2cdc8 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jun 21, 2023
@indutny @juanarbol
net: fix address iteration with autoSelectFamily
9ac4c9f 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Backport-PR-URL: nodejs#48275
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 7, 2023
@indutny @juanarbol
net: fix address iteration with autoSelectFamily
e4e363e 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Backport-PR-URL: nodejs#48275
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 13, 2023
@indutny @juanarbol
net: fix address iteration with autoSelectFamily
f1f6b38 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Backport-PR-URL: nodejs#48275
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 17, 2023
@indutny @juanarbol
net: fix address iteration with autoSelectFamily
f0d848a 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Backport-PR-URL: nodejs#48275
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Jul 26, 2023
@indutny @mhdawson
net: fix address iteration with autoSelectFamily
4af24bc 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Backport-PR-URL: nodejs#48275
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 4, 2023
@indutny @mhdawson
net: fix address iteration with autoSelectFamily
27a243f 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Backport-PR-URL: nodejs#48275
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@mhdawson mhdawson mentioned this pull request Aug 4, 2023
Closed
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@indutny @Ceres6
net: fix address iteration with autoSelectFamily
369b14c 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@indutny @Ceres6
net: fix address iteration with autoSelectFamily
52a7cab 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 14, 2023
@indutny @ruyadorno
net: fix address iteration with autoSelectFamily
d3637cd 
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: #48258
Backport-PR-URL: #49016
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@ruyadorno ruyadorno added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Aug 14, 2023
@ruyadorno ruyadorno mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@indutny @nodejs-github-bot @juanarbol @ShogunPanda @tniessen @lpinca @cjihrig @ruyadorno