Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v18.x] test: mark test-child-process-stdio-reuse-readable-stdio flaky #48601

Closed

Conversation

juanarbol
Copy link
Member

As mentioned #48345 (comment), this PR includes the current v18.x release line blockers to get any PR landed there. I hope this fixes the problems :)

MoLow and others added 2 commits June 29, 2023 09:56
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Jun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanarbol juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 1, 2023
@juanarbol
Copy link
Member Author

Landed in fb90b6b...2edd0fd

@juanarbol juanarbol closed this Jul 4, 2023
@juanarbol juanarbol deleted the v18.x-staging-flaky-tests branch December 6, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants