Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: protect against user mutating well-known prototypes #49270

Merged
merged 1 commit into from
Aug 23, 2023
Merged

worker: protect against user mutating well-known prototypes #49270

merged 1 commit into from
Aug 23, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 21, 2023

Fixes: #49259

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Aug 21, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53473/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit bca14f8 into nodejs:main Aug 23, 2023
37 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bca14f8

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@aduh95 @UlisesGascon
worker: protect against user mutating well-known prototypes
0179c6d 
PR-URL: #49270
Fixes: #49259
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@aduh95 @alexfernandez
worker: protect against user mutating well-known prototypes
e79b5d2 
PR-URL: nodejs#49270
Fixes: nodejs#49259
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@aduh95 @targos
worker: protect against user mutating well-known prototypes
879b958 
PR-URL: #49270
Fixes: #49259
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
worker: protect against user mutating well-known prototypes
40a0726 
PR-URL: nodejs/node#49270
Fixes: nodejs/node#49259
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
worker: protect against user mutating well-known prototypes
5685636 
PR-URL: nodejs/node#49270
Fixes: nodejs/node#49259
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhafraDev KhafraDev KhafraDev approved these changes

@anonrig anonrig anonrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Freezing EventTarget.prototype breaks MessageChannel
6 participants
@aduh95 @nodejs-github-bot @bnoordhuis @benjamingr @anonrig @KhafraDev