Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: Don't accumulate excess indentation in .load #49461

Merged
merged 1 commit into from
Sep 21, 2023
Merged

repl: Don't accumulate excess indentation in .load #49461

merged 1 commit into from
Sep 21, 2023

Conversation

STRd6
Copy link
Contributor

@STRd6 STRd6 commented Sep 2, 2023 •
edited
Loading

When using .load the REPL would accumulate indentation with each line
including the indentation from all previous lines. Now it keeps the
indentation at the correct level.

Fixes: #47673

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Sep 2, 2023
@STRd6 STRd6 mentioned this pull request Sep 2, 2023
Open
@STRd6 STRd6 changed the title Fix #47673 repl: Don't accumulate excess indentation in .load Sep 2, 2023
aduh95
aduh95 reviewed Sep 3, 2023
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, could you please add a test?

lib/repl.js Outdated Show resolved Hide resolved
@aduh95
Copy link
Contributor

aduh95 commented Sep 3, 2023

/cc @nodejs/repl

@STRd6
repl: don't accumulate excess indentation in .load
3385323 
When using .load the REPL would accumulate indentation with each line
including the indentation from all previous lines. Now it keeps the
indentation at the correct level.

Fixes: nodejs#47673
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53784/

This was referenced Sep 8, 2023
Open
Open
Open
Open
cola119
cola119 approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@cola119 cola119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53994/

@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54000/

This was referenced Sep 18, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54091/

@cola119 cola119 added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Sep 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit f7414a8 into nodejs:main Sep 21, 2023
67 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f7414a8

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@STRd6 @ruyadorno
repl: don't accumulate excess indentation in .load
8a7c101 
When using .load the REPL would accumulate indentation with each line
including the indentation from all previous lines. Now it keeps the
indentation at the correct level.

Fixes: #47673
PR-URL: #49461
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@STRd6 @alexfernandez
repl: don't accumulate excess indentation in .load
1108fa5 
When using .load the REPL would accumulate indentation with each line
including the indentation from all previous lines. Now it keeps the
indentation at the correct level.

Fixes: nodejs#47673
PR-URL: nodejs#49461
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@cola119 cola119 cola119 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.load accumulates indentation
4 participants
@STRd6 @aduh95 @nodejs-github-bot @cola119