errors: improve performance of determineSpecificType #49696

Uzlopak · 2023-09-18T03:57:53Z

This PR improves the function determineSpecificType in errors.js.

Also fixes a bug, where a string would be sliced without the single tick at the end of the string.

Added unit tests. Added benchmarks based on unit tests.

main:

error/determine-specific-type.js v="() => 1n" n=1000000: 6,843,920.840090735
error/determine-specific-type.js v="() => true" n=1000000: 9,456,016.191725645
error/determine-specific-type.js v="() => false" n=1000000: 8,851,588.609212818
error/determine-specific-type.js v="() => 2" n=1000000: 9,901,905.486054687
error/determine-specific-type.js v="() => +0" n=1000000: 8,973,347.793105612
error/determine-specific-type.js v="() => -0" n=1000000: 10,751,000.496169424
error/determine-specific-type.js v="() => NaN" n=1000000: 10,215,963.841045486
error/determine-specific-type.js v="() => Infinity" n=1000000: 10,320,438.148834981
error/determine-specific-type.js v="() => \"\"" n=1000000: 6,254,431.929555482
error/determine-specific-type.js v="() => Symbol(\"foo\")" n=1000000: 5,327,156.757878972
error/determine-specific-type.js v="() => function foo() {}" n=1000000: 28,370,147.240213074
error/determine-specific-type.js v="() => null" n=1000000: 84,447,833.61750029
error/determine-specific-type.js v="() => undefined" n=1000000: 143,308,256.7768683
error/determine-specific-type.js v="() => new Array()" n=1000000: 17,252,357.461324573
error/determine-specific-type.js v="() => new BigInt64Array()" n=1000000: 21,056,043.101214882
error/determine-specific-type.js v="() => new BigUint64Array()" n=1000000: 22,987,115.95138041
error/determine-specific-type.js v="() => new Int8Array()" n=1000000: 22,238,571.03126347
error/determine-specific-type.js v="() => new Int16Array()" n=1000000: 20,920,369.479666267
error/determine-specific-type.js v="() => new Int32Array()" n=1000000: 22,552,915.624017186
error/determine-specific-type.js v="() => new Float32Array()" n=1000000: 22,731,474.433672026
error/determine-specific-type.js v="() => new Float64Array()" n=1000000: 21,389,880.191003073
error/determine-specific-type.js v="() => new Uint8Array()" n=1000000: 22,209,250.046039775
error/determine-specific-type.js v="() => new Uint8ClampedArray()" n=1000000: 21,585,063.757529628
error/determine-specific-type.js v="() => new Uint16Array()" n=1000000: 22,708,905.351735055
error/determine-specific-type.js v="() => new Uint32Array()" n=1000000: 22,544,499.855568662
error/determine-specific-type.js v="() => new Date()" n=1000000: 27,342,526.528744582
error/determine-specific-type.js v="() => new Map()" n=1000000: 26,338,839.423816815
error/determine-specific-type.js v="() => new WeakMap()" n=1000000: 25,778,798.114064377
error/determine-specific-type.js v="() => new Object()" n=1000000: 20,142,102.12766866
error/determine-specific-type.js v="() => Promise.resolve(\"foo\")" n=1000000: 26,109,976.21198397
error/determine-specific-type.js v="() => new Set()" n=1000000: 25,905,614.964326676
error/determine-specific-type.js v="() => new WeakSet()" n=1000000: 25,752,138.193596177
error/determine-specific-type.js v="() => ({ __proto__: null })" n=1000000: 1,271,014.61081246

PR:

error/determine-specific-type.js v="() => 1n" n=1000000: 20,725,839.6296707
error/determine-specific-type.js v="() => true" n=1000000: 140,278,463.97326404
error/determine-specific-type.js v="() => false" n=1000000: 146,549,885.94755125
error/determine-specific-type.js v="() => 2" n=1000000: 49,945,631.68263187
error/determine-specific-type.js v="() => +0" n=1000000: 127,743,303.4086129
error/determine-specific-type.js v="() => -0" n=1000000: 123,600,395.47182535
error/determine-specific-type.js v="() => NaN" n=1000000: 153,607,424.2769161
error/determine-specific-type.js v="() => Infinity" n=1000000: 137,883,393.39304143
error/determine-specific-type.js v="() => \"\"" n=1000000: 47,073,709.89790654
error/determine-specific-type.js v="() => \"'\"" n=1000000: 8,823,294.789975893
error/determine-specific-type.js v="() => Symbol(\"foo\")" n=1000000: 11,643,085.227570156
error/determine-specific-type.js v="() => function foo() {}" n=1000000: 24,384,259.05368641
error/determine-specific-type.js v="() => null" n=1000000: 223,003,179.3563281
error/determine-specific-type.js v="() => undefined" n=1000000: 203,319,433.73911148
error/determine-specific-type.js v="() => new Array()" n=1000000: 35,201,357.92758342
error/determine-specific-type.js v="() => new BigInt64Array()" n=1000000: 21,667,733.83867111
error/determine-specific-type.js v="() => new BigUint64Array()" n=1000000: 17,649,319.59755033
error/determine-specific-type.js v="() => new Int8Array()" n=1000000: 22,205,003.47563817
error/determine-specific-type.js v="() => new Int16Array()" n=1000000: 21,894,023.991121184
error/determine-specific-type.js v="() => new Int32Array()" n=1000000: 21,752,199.72382537
error/determine-specific-type.js v="() => new Float32Array()" n=1000000: 20,549,685.59494782
error/determine-specific-type.js v="() => new Float64Array()" n=1000000: 21,237,781.66528292
error/determine-specific-type.js v="() => new Uint8Array()" n=1000000: 21,616,408.912246525
error/determine-specific-type.js v="() => new Uint8ClampedArray()" n=1000000: 20,134,607.096901342
error/determine-specific-type.js v="() => new Uint16Array()" n=1000000: 18,759,458.753596798
error/determine-specific-type.js v="() => new Uint32Array()" n=1000000: 21,513,774.5814237
error/determine-specific-type.js v="() => new Date()" n=1000000: 34,218,765.56419165
error/determine-specific-type.js v="() => new Map()" n=1000000: 31,749,019.17755055
error/determine-specific-type.js v="() => new WeakMap()" n=1000000: 23,849,589.985003855
error/determine-specific-type.js v="() => new Object()" n=1000000: 34,675,541.47851863
error/determine-specific-type.js v="() => Promise.resolve(\"foo\")" n=1000000: 34,478,485.66629363
error/determine-specific-type.js v="() => new Set()" n=1000000: 31,878,517.854217436
error/determine-specific-type.js v="() => new WeakSet()" n=1000000: 34,144,917.037412174
error/determine-specific-type.js v="() => ({ __proto__: null })" n=1000000: 1,280,069.176986435

Uzlopak · 2023-09-20T14:10:45Z

@anonrig

can you mark this as author-ready please?

anonrig · 2023-09-20T14:13:01Z

can you mark this as author-ready please?

The tests are failing @Uzlopak

Uzlopak · 2023-09-20T14:17:29Z

Oha. Will focus on this when the other PR got merged.

Uzlopak · 2023-09-20T21:51:14Z

@anonrig
fixed

nodejs-github-bot · 2023-09-20T21:56:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54096/

nodejs-github-bot · 2023-09-20T23:32:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54098/

nodejs-github-bot · 2023-09-21T05:27:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54102/

Uzlopak · 2023-09-22T13:23:43Z

@anonrig

Can this be merged?

anonrig · 2023-09-25T19:05:12Z

We can merge this once the CI finishes.

Pending benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1420/

nodejs-github-bot · 2023-09-25T19:11:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54226/

nodejs-github-bot · 2023-09-26T00:02:28Z

Commit Queue failed

- Loading data for nodejs/node/pull/49696
✔  Done loading data for nodejs/node/pull/49696
----------------------------------- PR info ------------------------------------
Title      errors: improve performance of determineSpecificType (#49696)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Uzlopak:improve-determine-specific-type -> nodejs:main
Labels     errors, author ready, needs-ci, needs-benchmark-ci, commit-queue-squash
Commits    8
 - errors: improve performance of determine-specific-type
 - fix lint
 - fix lint
 - fix function serialization
 - Merge branch 'main' into improve-determine-specific-type
 - fix invalidArgTypeHelper
 - fix test
 - Merge branch 'main' into improve-determine-specific-type
Committers 2
 - uzlopak 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49696
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49696
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 18 Sep 2023 03:57:53 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49696#pullrequestreview-1642824192
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49696#pullrequestreview-1636924932
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-25T19:11:17Z: https://ci.nodejs.org/job/node-test-pull-request/54226/
   ℹ  Last Benchmark CI on 2023-09-25T19:05:12Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1420/
- Querying data for job/node-test-pull-request/54226/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49696
From https://github.com/nodejs/node
 * branch                  refs/pull/49696/merge -> FETCH_HEAD
✔  Fetched commits as f16f41c5b3cf..3d4b956b2292
--------------------------------------------------------------------------------
Auto-merging lib/internal/errors.js
[main 2ca76c9a83] errors: improve performance of determine-specific-type
 Author: uzlopak 
 Date: Mon Sep 18 05:56:37 2023 +0200
 3 files changed, 136 insertions(+), 15 deletions(-)
 create mode 100644 benchmark/error/determine-specific-type.js
Auto-merging lib/internal/errors.js
[main 6873f4acda] fix lint
 Author: uzlopak 
 Date: Mon Sep 18 06:04:59 2023 +0200
 1 file changed, 3 insertions(+), 3 deletions(-)
[main 1cdfaf7533] fix lint
 Author: uzlopak 
 Date: Mon Sep 18 06:07:13 2023 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging lib/internal/errors.js
error: commit 99f6196abb3604436614d0f18a406b14be2cc0b1 is a merge but no -m option was given.
fatal: cherry-pick failed
[main d4c38b51f3] fix function serialization
 Author: uzlopak 
 Date: Mon Sep 18 19:00:20 2023 +0200
 2 files changed, 34 insertions(+), 5 deletions(-)
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/6306204198

nodejs-github-bot · 2023-09-29T03:42:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54348/

nodejs-github-bot · 2023-09-29T11:35:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54367/

nodejs-github-bot · 2023-09-30T02:49:42Z

Commit Queue failed

- Loading data for nodejs/node/pull/49696
✔  Done loading data for nodejs/node/pull/49696
----------------------------------- PR info ------------------------------------
Title      errors: improve performance of determineSpecificType (#49696)
Author     Aras Abbasi  (@Uzlopak)
Branch     Uzlopak:improve-determine-specific-type -> nodejs:main
Labels     errors, author ready, needs-ci, needs-benchmark-ci, commit-queue-squash
Commits    1
 - errors: improve performance of determine-specific-type
Committers 1
 - uzlopak 
PR-URL: https://github.com/nodejs/node/pull/49696
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49696
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 18 Sep 2023 03:57:53 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49696#pullrequestreview-1649996712
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49696#pullrequestreview-1636924932
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-29T11:35:22Z: https://ci.nodejs.org/job/node-test-pull-request/54367/
   ℹ  Last Benchmark CI on 2023-09-26T00:02:28Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1420/
- Querying data for job/node-test-pull-request/54367/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49696
From https://github.com/nodejs/node
 * branch                  refs/pull/49696/merge -> FETCH_HEAD
✔  Fetched commits as 51f4ff245018..d3bd644908c9
--------------------------------------------------------------------------------
error: cherry-pick is already in progress
hint: try "git cherry-pick (--continue | --abort | --quit)"
fatal: cherry-pick failed
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/6359670729

nodejs-github-bot · 2023-09-30T21:43:41Z

Landed in 0ee9c83

PR-URL: nodejs#49696 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

PR-URL: #49696 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

PR-URL: nodejs#49696 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Sep 18, 2023

Uzlopak changed the title ~~errors: improve performance of determine-specific-type~~ errors: improve performance of determineSpecificType Sep 18, 2023

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2023

anonrig approved these changes Sep 20, 2023

View reviewed changes

anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-benchmark-ci PR that need a benchmark CI run. labels Sep 20, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2023

github-actions bot mentioned this pull request Sep 21, 2023

CI Reliability 2023-09-21 nodejs/reliability#672

Open

22 tasks

MoLow approved these changes Sep 21, 2023

View reviewed changes

github-actions bot mentioned this pull request Sep 22, 2023

CI Reliability 2023-09-22 nodejs/reliability#673

Open

17 tasks

This was referenced Sep 23, 2023

CI Reliability 2023-09-23 nodejs/reliability#674

Open

CI Reliability 2023-09-24 nodejs/reliability#675

Open

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

anonrig approved these changes Sep 25, 2023

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

anonrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 25, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 26, 2023

errors: improve performance of determine-specific-type

d3bd644

Uzlopak force-pushed the improve-determine-specific-type branch from 3d4b956 to d3bd644 Compare September 27, 2023 16:35

H4ad mentioned this pull request Sep 29, 2023

Node errors are very slow to create nodejs/performance#40

Open

anonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 29, 2023

anonrig approved these changes Sep 29, 2023

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023

github-actions bot mentioned this pull request Sep 30, 2023

CI Reliability 2023-09-30 nodejs/reliability#679

Open

31 tasks

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 30, 2023

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 30, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2023

nodejs-github-bot merged commit 0ee9c83 into nodejs:main Sep 30, 2023
61 checks passed

Uzlopak deleted the improve-determine-specific-type branch September 30, 2023 22:01

GeoffreyBooth pushed a commit to GeoffreyBooth/node that referenced this pull request Oct 1, 2023

errors: improve performance of determine-specific-type

8c8062c

PR-URL: nodejs#49696 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

RafaelGSS mentioned this pull request Oct 9, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023

errors: improve performance of determine-specific-type

0d897e7

PR-URL: nodejs#49696 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

targos pushed a commit that referenced this pull request Nov 11, 2023

errors: improve performance of determine-specific-type

c255575

PR-URL: #49696 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

targos mentioned this pull request Nov 12, 2023

v20.10.0 release proposal #50682

Merged

juanarbol mentioned this pull request Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024

errors: improve performance of determine-specific-type

b19350e

PR-URL: nodejs#49696 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

errors: improve performance of determineSpecificType #49696

errors: improve performance of determineSpecificType #49696

Uzlopak commented Sep 18, 2023 •

edited

Loading

Uzlopak commented Sep 20, 2023

anonrig commented Sep 20, 2023

Uzlopak commented Sep 20, 2023

Uzlopak commented Sep 20, 2023

nodejs-github-bot commented Sep 20, 2023

nodejs-github-bot commented Sep 20, 2023

nodejs-github-bot commented Sep 21, 2023

Uzlopak commented Sep 22, 2023

anonrig commented Sep 25, 2023

nodejs-github-bot commented Sep 25, 2023

nodejs-github-bot commented Sep 26, 2023

nodejs-github-bot commented Sep 29, 2023

nodejs-github-bot commented Sep 29, 2023

nodejs-github-bot commented Sep 30, 2023

nodejs-github-bot commented Sep 30, 2023

errors: improve performance of determineSpecificType #49696

errors: improve performance of determineSpecificType #49696

Conversation

Uzlopak commented Sep 18, 2023 • edited Loading

Uzlopak commented Sep 20, 2023

anonrig commented Sep 20, 2023

Uzlopak commented Sep 20, 2023

Uzlopak commented Sep 20, 2023

nodejs-github-bot commented Sep 20, 2023

nodejs-github-bot commented Sep 20, 2023

nodejs-github-bot commented Sep 21, 2023

Uzlopak commented Sep 22, 2023

anonrig commented Sep 25, 2023

nodejs-github-bot commented Sep 25, 2023

nodejs-github-bot commented Sep 26, 2023

nodejs-github-bot commented Sep 29, 2023

nodejs-github-bot commented Sep 29, 2023

nodejs-github-bot commented Sep 30, 2023

nodejs-github-bot commented Sep 30, 2023

Uzlopak commented Sep 18, 2023 •

edited

Loading