Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: backport --predictable related changes to V8 #49703

Closed
wants to merge 2 commits into from

Commits on Sep 18, 2023

  1. deps: V8: cherry-pick b33bf2dfd261

    Original commit message:
    
        Ignore --predictable when computing flag list hashes
    
        This allows reproducible code cache generation.
    
        Refs: nodejs#48749
    
        Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
        Reviewed-by: Leszek Swirski <[email protected]>
        Commit-Queue: Joyee Cheung <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#88943}
    
    Refs: v8/v8@b33bf2d
    joyeecheung committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    8f4e632 View commit details
    Browse the repository at this point in the history
  2. deps: V8: backport de9a5de2274f

    Original commit message:
    
        Ignore flags implied by --predictable during hash computation
    
        https://chromium-review.googlesource.com/c/v8/v8/+/4681766 added
        code to ignore --predictable during hash computation of flags
        in order to produce reproducible code cache. This turns out to
        be not enough since the flags implied by --predictable also
        need to be ignored for it to work. This patch makes sure that
        they are ignored.
    
        Change-Id: Ifa36641efe3ca105706fd293be46fc974055d2d4
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851287
        Commit-Queue: Joyee Cheung <[email protected]>
        Reviewed-by: Leszek Swirski <[email protected]>
        Reviewed-by: Patrick Thier <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#90022}
    
    Refs: v8/v8@de9a5de
    joyeecheung committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    308af9f View commit details
    Browse the repository at this point in the history