test: add EOVERFLOW as an allowed error #50128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
in test-fs-read-promises-position-validation.mjs As stated in nodejs#50054 This looks like an oversight as test-fs-read-position-validation.mjs includes EOVERFLOW as an allowed error. Fixes nodejs#50054
abmusse
force-pushed
the
fix-parallel-test-fs-read-promises-position-validation
branch
from
da380ab
to
a5f5257
Compare
lpinca
approved these changes
Oct 10, 2023
richardlau
approved these changes
Oct 10, 2023
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Oct 10, 2023
30 tasks
richardlau
added
the
commit-queue
|
https://ci.nodejs.org/job/node-test-commit-ibmi/1325/ shows the test now passes with this PR. The test-runner-cli-concurrency failure there will be addressed by #50108. |
nodejs-github-bot
removed
the
commit-queue
|
Landed in f0e720a |
abmusse
deleted the
fix-parallel-test-fs-read-promises-position-validation
branch
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
in test-fs-read-promises-position-validation.mjs As stated in nodejs#50054 This looks like an oversight as test-fs-read-position-validation.mjs includes EOVERFLOW as an allowed error. Fixes nodejs#50054 PR-URL: nodejs#50128 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos
added
dont-land-on-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in test-fs-read-promises-position-validation.mjs
As stated in #50054
This looks like an oversight as
test-fs-read-position-validation.mjs includes
EOVERFLOW as an allowed error.
Fixes #50054
CC @nodejs/platform-ibmi