Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach() with for-loop #50596

Merged
merged 1 commit into from
Nov 18, 2023
Merged

test: replace forEach() with for-loop #50596

merged 1 commit into from
Nov 18, 2023

Conversation

jabro86
Copy link
Contributor

@jabro86 jabro86 commented Nov 7, 2023

NodeConf

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@RafaelGSS RafaelGSS added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
RafaelGSS
RafaelGSS reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add git email and username please

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55481/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2023
@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/50596
✔  Done loading data for nodejs/node/pull/50596
----------------------------------- PR info ------------------------------------
Title      test: replace forEach() with for-loop (#50596)
Author     Jan  (@jabro86, first-time contributor)
Branch     jabro86:for-loop-test-trace-events -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci
Commits    1
 - test: replace forEach() with for-loop
Committers 1
 - Jan Brockmeyer 
PR-URL: https://github.com/nodejs/node/pull/50596
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50596
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 07 Nov 2023 15:08:25 GMT
   ✔  Approvals: 3
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50596#pullrequestreview-1717952006
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50596#pullrequestreview-1718212674
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50596#pullrequestreview-1718810431
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ⚠  GitHub cannot link the author of 'test: replace forEach() with for-loop' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-07T15:20:39Z: https://ci.nodejs.org/job/node-test-pull-request/55481/
- Querying data for job/node-test-pull-request/55481/
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @jabro86([email protected])
   ⚠  - commit 2488cbc834b1 is authored by [email protected]
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6813781442

@jabro86
Copy link
Contributor Author

jabro86 commented Nov 9, 2023

My previous commit was still using a wrong email address. should be fixed now 😺

@debadree25 debadree25 added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55531/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55543/

@github-actions github-actions bot mentioned this pull request Nov 11, 2023
Open
27 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55565/

This was referenced Nov 12, 2023
Open
Open
Open
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit 59ebf6d into nodejs:main Nov 18, 2023
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 59ebf6d

targos pushed a commit that referenced this pull request Nov 23, 2023
@jabro86 @targos
test: replace forEach() with for-loop
278c768 
PR-URL: #50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@jabro86 @martenrichter
test: replace forEach() with for-loop
722b172 
PR-URL: nodejs#50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@jabro86
test: replace forEach() with for-loop
0169a09 
PR-URL: nodejs#50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@jabro86 @RafaelGSS
test: replace forEach() with for-loop
f2e0fce 
PR-URL: #50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@jabro86 @RafaelGSS
test: replace forEach() with for-loop
e1bc1cc 
PR-URL: #50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@jabro86 @UlisesGascon
test: replace forEach() with for-loop
6b21cca 
PR-URL: #50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@jabro86 @UlisesGascon
test: replace forEach() with for-loop
6584dd8 
PR-URL: #50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 mentioned this pull request May 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jabro86 @nodejs-github-bot @jasnell @lpinca @RafaelGSS @marco-ippolito @debadree25