src: add `--disable-warning` option #50661

Ethan-Arrowood · 2023-11-10T17:19:44Z

Fixes: #30810
Fixes: #47478
Fixes: #46862
Fixes: #40940

This PR adds a new --disable-warning option that allows users to disable specific warnings either by code (i.e. DEP0025) or type (i.e. DeprecationWarning, ExperimentalWarning).

This option works alongside existing --warnings and --no-warnings.

The implementation is based off of @jasnell comment here: #31000 (comment) and a previous TSC agreement noted here: #31000 (comment)

I maintain that my preference is for an option to disable individual experimental warnings by code/id as opposed to all warnings, and for that not to be permitted on NODE_OPTIONS.

We discussed in the TSC meeting today (note we only had 6 people so a smallish subset). From the discussion there would be no objection from those who were there if there was an option to disabled specific experimental warnings and that was also supported in NODE_OPTIONS.

@bnoordhuis comment here #30810 (comment) is incorrect. --no-warnings does not accept a string. It is only a boolean flag. Passing anything to it disables all flags (I've added a test to confirm this). Issue #46862 is also invalid for the same reason. This new flag will achieve the same effect though. This was also proposed in another PR review comment (#36137 (review)), but I asked if this was even possible in the Node.js Slack and @aduh95 confirmed it was not possible.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

anonrig · 2023-11-10T18:04:08Z

I'm -1. I'm afraid this promotes using code that is deprecated/expected to be removed.

Ethan-Arrowood · 2023-11-10T18:07:11Z

The major argument made in previous threads/discussions is that since this is a manual, opt-in flag, it's left up to the users to use good judgement. If I have done my research, and am happy using a deprecated or experimental feature, I should have a way to disable that specific warning message without having to introduce some monkey-patching of process.emitWarning (which is the current work around).

This option is not available on NODE_ENV so it's very obvious when it is enabled.

We already have --no-deprecation to disable deprecation warnings specifically. Why not something for experimental warnings (or any kind of warnings for that matter)?

doc/api/cli.md

test/sequential/test-process-disable-warnings.js

wesleytodd · 2023-11-10T18:16:00Z

I'm -1. I'm afraid this promotes using code that is deprecated/expected to be removed.

@anonrig I am not sure this works out in reality. For example, today most of the places I use --no-warnings today is when I am passing the output to other things and the usage is deep in a transitive dep. It has nothing to do with me using old features. I think it is better for us to offer selective off switches for the things than only have a global off switch.

Ethan-Arrowood · 2023-11-10T18:19:00Z

I've added much more context including a previous TSC agreement comment to the PR body. I'd like us to not have the same debates as before. If this needs to be rediscussed at the TSC level so be it, and I encourage folks to read prior threads too.

anonrig · 2023-11-10T18:24:12Z

I didn't block the PR. I'm just sharing my thoughts on this. Can you elaborate on the reasoning for hiding a specific warning? What's the benefit of hiding a warning, rather than all warnings? Why would someone want to hide specific warnings?

wesleytodd · 2023-11-10T18:34:07Z

Why would someone want to hide specific warnings?

My thinking about being more "fine grained" here is that it incentivizes dealing with the warnings they can without resorting to silencing all of them and then getting bit by not knowing they were using a deprecated feature.

Ethan-Arrowood · 2023-11-10T18:38:19Z

Can you elaborate on the reasoning for hiding a specific warning? What's the benefit of hiding a warning, rather than all warnings? Why would someone want to hide specific warnings?

This has been discussed in previous threads; I'll do my best to readdress it.

At a minimum, if I'm content using experimental features, I should have a way to disable those warnings (disable warning by type). Furthermore, if I am supporting some kind of legacy code path, and am content using a deprecated feature, I should have a way to disable specifically that deprecation warning, and not any others (disable warning by code). By "content" I mean that I have done my research and making the conscious decision to use something that may eventually be removed or changed. There are legitimate cases for this, such as maintaining an update branch of a project which runs on the latest version of Node.js in order to be prepared for future LTS changes.

Also mentioned in previous threads, Experimental Feature warnings should start using code, but that will come in a separate PR (I'll also contribute it).

mcollina · 2023-11-10T18:54:38Z

Could you add an API to do this programmatically?
Could you add a test that verifies this is passed through correctly to worker_threads? (they can have their own node options)

test/fixtures/disable-warnings.js

test/sequential/test-process-disable-warnings.js

GeoffreyBooth · 2023-11-10T19:36:34Z

I think this should be available in NODE_OPTIONS. Now that we're using .env files as de facto config files, we really shouldn't have any options that can't be specified in NODE_OPTIONS.

Ethan-Arrowood · 2023-11-10T20:10:08Z

@GeoffreyBooth

I think this should be available in NODE_OPTIONS. Now that we're using .env files as de facto config files, we really shouldn't have any options that can't be specified in NODE_OPTIONS.

I'll defer to @jasnell as he was the one who previously commented against this position.

I'm happy to support either way.

Ethan-Arrowood · 2023-11-10T20:11:10Z

@mcollina

Could you add an API to do this programmatically?

Do you mean something like process.disableWarnings(['DEP0025', 'ExperimentalWarning']) ?

Could you add a test that verifies this is passed through correctly to worker_threads? (they can have their own node options)

Yes 👍

test/parallel/test-process-warnings.mjs

lib/internal/process/warning.js

Co-authored-by: Geoffrey Booth <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: nodejs#50661 Fixes: nodejs#30810 Fixes: nodejs#47478 Fixes: nodejs#46862 Fixes: nodejs#40940 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805 deps: * add simdjson (Yagiz Nizipli) #50322 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884 module: * merge config with `package_json_reader` (Yagiz Nizipli) #50322 * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655 * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661 * move package resolver to c++ (Yagiz Nizipli) #50322 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655 * (SEMVER-MINOR) create fs_dir per isolate properties (Chengzhong Wu) #48655 * (SEMVER-MINOR) create worker per isolate properties (Chengzhong Wu) #48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655 PR-URL: TODO

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805 deps: * add simdjson (Yagiz Nizipli) #50322 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884 module: * merge config with `package_json_reader` (Yagiz Nizipli) #50322 * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655 * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661 * move package resolver to c++ (Yagiz Nizipli) #50322 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655 * (SEMVER-MINOR) create fs_dir per isolate properties (Chengzhong Wu) #48655 * (SEMVER-MINOR) create worker per isolate properties (Chengzhong Wu) #48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655 PR-URL: #50954

Co-authored-by: Geoffrey Booth <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #50661 Fixes: #30810 Fixes: #47478 Fixes: #46862 Fixes: #40940 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884 module: * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655 * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655 * (SEMVER-MINOR) create fs_dir per isolate properties (Chengzhong Wu) #48655 * (SEMVER-MINOR) create worker per isolate properties (Chengzhong Wu) #48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655 PR-URL: #50954

Co-authored-by: Geoffrey Booth <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #50661 Fixes: #30810 Fixes: #47478 Fixes: #46862 Fixes: #40940 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884 module: * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655 * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655 * (SEMVER-MINOR) create fs_dir per isolate properties (Chengzhong Wu) #48655 * (SEMVER-MINOR) create worker per isolate properties (Chengzhong Wu) #48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655 PR-URL: #50954

MattIPv4 · 2023-11-30T18:57:43Z

👋 Is this change a candidate for back-porting into 20.x/18.x? (Congrats on getting this out in 21.x)

Co-authored-by: Geoffrey Booth <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #50661 Fixes: #30810 Fixes: #47478 Fixes: #46862 Fixes: #40940 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805 doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884 module: * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655 stream: * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: TODO

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805 doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884 module: * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655 stream: * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #51124

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805 doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884 module: * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655 * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655 stream: * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #51124

Co-authored-by: Geoffrey Booth <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #50661 Fixes: #30810 Fixes: #47478 Fixes: #46862 Fixes: #40940 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805 doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884 module: * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655 * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655 stream: * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #51124

Co-authored-by: Geoffrey Booth <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #50661 Fixes: #30810 Fixes: #47478 Fixes: #46862 Fixes: #40940 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805 doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884 module: * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655 * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655 stream: * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #51124

Notable changes: crypto: * update root certificates to NSS 3.95 (Node.js GitHub Bot) nodejs#50805 doc: * add MrJithil to collaborators (Jithil P Ponnan) nodejs#50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) nodejs#50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) nodejs#48740 fs: * add c++ fast path for writeFileSync utf8 (CanadaHonk) nodejs#49884 module: * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) nodejs#48655 * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) nodejs#48655 src: * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) nodejs#50661 * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) nodejs#48655 * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) nodejs#48655 stream: * use Array for Readable buffer (Robert Nagy) nodejs#50341 * optimize creation (Robert Nagy) nodejs#50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) nodejs#50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) nodejs#48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) nodejs#50443 PR-URL: nodejs#51124

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Nov 10, 2023

Ethan-Arrowood marked this pull request as ready for review November 10, 2023 17:51

richardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 10, 2023

Ethan-Arrowood force-pushed the feat/disable-warnings-option branch from 13a7539 to 9a66223 Compare November 10, 2023 18:02

GeoffreyBooth reviewed Nov 10, 2023

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

doc/api/cli.md Outdated Show resolved Hide resolved

test/sequential/test-process-disable-warnings.js Outdated Show resolved Hide resolved

test/sequential/test-process-disable-warnings.js Outdated Show resolved Hide resolved

aduh95 reviewed Nov 10, 2023

View reviewed changes

test/fixtures/disable-warnings.js Outdated Show resolved Hide resolved

aduh95 reviewed Nov 10, 2023

View reviewed changes

test/sequential/test-process-disable-warnings.js Outdated Show resolved Hide resolved

Ethan-Arrowood force-pushed the feat/disable-warnings-option branch 2 times, most recently from 37ae57e to 28f61ad Compare November 10, 2023 20:08

aduh95 reviewed Nov 10, 2023

View reviewed changes

test/parallel/test-process-warnings.mjs Outdated Show resolved Hide resolved

anonrig reviewed Nov 10, 2023

View reviewed changes

lib/internal/process/warning.js Outdated Show resolved Hide resolved

Ethan-Arrowood force-pushed the feat/disable-warnings-option branch 3 times, most recently from 78efd64 to 834187b Compare November 10, 2023 22:59

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2023

GeoffreyBooth reviewed Nov 10, 2023

View reviewed changes

lib/internal/process/warning.js Outdated Show resolved Hide resolved

RafaelGSS mentioned this pull request Nov 28, 2023

v21.3.0 proposal #50954

Merged

karlhorky mentioned this pull request Dec 3, 2023

Upgrade to prettier 3 nene/prettier-plugin-sql-cst#11

Merged

UlisesGascon mentioned this pull request Dec 12, 2023

v20.11.0 proposal #51124

Merged

aspiers mentioned this pull request Dec 30, 2023

use of experimental node features causes warnings Jonghakseo/chrome-extension-boilerplate-react-vite#342

Closed

tcrasset mentioned this pull request Aug 24, 2024

refactor app-simplefin.ts to make it easily testable actualbudget/actual-server#440

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: add `--disable-warning` option #50661

src: add `--disable-warning` option #50661

Ethan-Arrowood commented Nov 10, 2023 •

edited

Loading

anonrig commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

wesleytodd commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

anonrig commented Nov 10, 2023

wesleytodd commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

mcollina commented Nov 10, 2023

GeoffreyBooth commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

MattIPv4 commented Nov 30, 2023 •

edited

Loading

src: add --disable-warning option #50661

src: add --disable-warning option #50661

Conversation

Ethan-Arrowood commented Nov 10, 2023 • edited Loading

Checklist

anonrig commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

wesleytodd commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

anonrig commented Nov 10, 2023

wesleytodd commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

mcollina commented Nov 10, 2023

GeoffreyBooth commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

Ethan-Arrowood commented Nov 10, 2023

MattIPv4 commented Nov 30, 2023 • edited Loading

src: add `--disable-warning` option #50661

src: add `--disable-warning` option #50661

Ethan-Arrowood commented Nov 10, 2023 •

edited

Loading

MattIPv4 commented Nov 30, 2023 •

edited

Loading