Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick 0f9ebbc672c7 #50867

Merged
merged 1 commit into from
Nov 24, 2023
Merged

deps: V8: cherry-pick 0f9ebbc672c7 #50867

merged 1 commit into from
Nov 24, 2023

Conversation

legendecas
Copy link
Member

Original commit message:

[flags] Remove --harmony-string-is-well-formed

The String.prototype.isWellFormed and toWellFormed have shipped
since M111.

Bug: v8:13557
Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
Reviewed-by: Shu-yu Guo <[email protected]>
Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc

This patch has been released in v8 12.0. Cherry-pick to unblock #47342.

@legendecas
deps: V8: cherry-pick 0f9ebbc672c7
4217167 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 23, 2023
@legendecas legendecas mentioned this pull request Nov 23, 2023
Merged
@gengjiawen gengjiawen added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55873/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5684/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 23, 2023 •
edited by legendecas
Loading

✅V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5684/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 23, 2023 •
edited by legendecas
Loading

✅ V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5684/

@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit fbfa77b into nodejs:main Nov 24, 2023
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fbfa77b

@legendecas legendecas deleted the v8/string-well-formed branch November 24, 2023 03:42
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@legendecas @martenrichter
deps: V8: cherry-pick 0f9ebbc672c7
3324200 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@legendecas
deps: V8: cherry-pick 0f9ebbc672c7
4e92c1c 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@legendecas @RafaelGSS
deps: V8: cherry-pick 0f9ebbc672c7
fa988b0 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@legendecas @RafaelGSS
deps: V8: cherry-pick 0f9ebbc672c7
e02f304 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@legendecas @RafaelGSS
deps: V8: cherry-pick 0f9ebbc672c7
595da57 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
1d5eebd 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
e2aa879 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
db663b7 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 18, 2023
@legendecas @targos
deps: V8: cherry-pick 0f9ebbc672c7
f2dad10 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 18, 2023
@legendecas @targos
deps: V8: cherry-pick 0f9ebbc672c7
d6f1136 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
02faaba 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 21, 2023
@legendecas @targos
deps: V8: cherry-pick 0f9ebbc672c7
fba36f6 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 21, 2023
@legendecas @targos
deps: V8: cherry-pick 0f9ebbc672c7
edd6431 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 22, 2023
@legendecas @targos
deps: V8: cherry-pick 0f9ebbc672c7
b25e9fa 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 22, 2023
@legendecas @targos
deps: V8: cherry-pick 0f9ebbc672c7
bd28509 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Jan 4, 2024
@legendecas @targos
deps: V8: cherry-pick 0f9ebbc672c7
481a901 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #50115
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Jan 9, 2024
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
ec67890 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@legendecas @Medhansh404
deps: V8: cherry-pick 0f9ebbc672c7
f031466 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: nodejs#50115
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legendecas @nodejs-github-bot @anonrig @targos @gengjiawen @richardlau