Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: update interations and len in benchmark/util/text-decoder.js #50938

Merged
merged 1 commit into from
Dec 4, 2023
Merged

benchmark: update interations and len in benchmark/util/text-decoder.js #50938

merged 1 commit into from
Dec 4, 2023

Conversation

lucshi
Copy link

@lucshi lucshi commented Nov 27, 2023 •
edited by H4ad
Loading

benchmark: update interations and len in benchmark/util/text-decoder.js

Refs: #50571

To avoid long time testing, also shrinked the length to a shorter execution time but still reflecting the performance.

Belowing are the score improvement after 10X iteration change:

util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=0 encoding="utf-8": n=1000 percent=195.16%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=0 encoding="utf-8": n=1000 percent=195.50%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=0 encoding="utf-8": n=1000 percent=208.38%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=0 encoding="utf-8": n=1000 percent=455.98%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=0 encoding="utf-8": n=1000 percent=455.12%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=0 encoding="utf-8": n=1000 percent=130.19%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=0 encoding="utf-8": n=1000 percent=110.56%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=0 encoding="utf-8": n=1000 percent=112.78%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=0 encoding="utf-8": n=1000 percent=219.42%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=0 encoding="utf-8": n=1000 percent=209.79%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=0 encoding="utf-8": n=1000 percent=207.44%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=0 encoding="utf-8": n=1000 percent=363.22%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=0 encoding="utf-8": n=1000 percent=391.01%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=0 encoding="utf-8": n=1000 percent=110.74%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=0 encoding="utf-8": n=1000 percent=110.01%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=1 encoding="utf-8": n=1000 percent=209.34%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=1 encoding="utf-8": n=1000 percent=203.15%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=1 encoding="utf-8": n=1000 percent=230.26%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=1 encoding="utf-8": n=1000 percent=425.13%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=1 encoding="utf-8": n=1000 percent=414.33%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=1 encoding="utf-8": n=1000 percent=112.50%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=1 encoding="utf-8": n=1000 percent=112.87%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=1 encoding="utf-8": n=1000 percent=200.25%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=1 encoding="utf-8": n=1000 percent=198.14%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=1 encoding="utf-8": n=1000 percent=202.09%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=1 encoding="utf-8": n=1000 percent=409.94%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=1 encoding="utf-8": n=1000 percent=409.10%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=1 encoding="utf-8": n=1000 percent=111.46%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=1 encoding="utf-8": n=1000 percent=111.46%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=1 encoding="utf-8": n=1000 percent=111.23%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=0 encoding="latin1": n=1000 percent=167.00%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=0 encoding="latin1": n=1000 percent=177.66%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=0 encoding="latin1": n=1000 percent=186.68%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=0 encoding="latin1": n=1000 percent=178.14%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=0 encoding="latin1": n=1000 percent=183.53%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=0 encoding="latin1": n=1000 percent=179.09%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=0 encoding="latin1": n=1000 percent=111.61%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=0 encoding="latin1": n=1000 percent=187.75%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=0 encoding="latin1": n=1000 percent=168.16%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=0 encoding="latin1": n=1000 percent=178.63%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=0 encoding="latin1": n=1000 percent=184.81%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=0 encoding="latin1": n=1000 percent=186.54%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=0 encoding="latin1": n=1000 percent=182.40%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=1 encoding="latin1": n=1000 percent=178.20%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=1 encoding="latin1": n=1000 percent=183.54%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=1 encoding="latin1": n=1000 percent=176.17%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=1 encoding="latin1": n=1000 percent=180.91%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=1 encoding="latin1": n=1000 percent=184.76%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=1 encoding="latin1": n=1000 percent=188.66%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=1 encoding="latin1": n=1000 percent=111.11%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=1 encoding="latin1": n=1000 percent=177.94%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=1 encoding="latin1": n=1000 percent=175.18%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=1 encoding="latin1": n=1000 percent=184.49%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=1 encoding="latin1": n=1000 percent=182.09%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=1 encoding="latin1": n=1000 percent=178.55%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=1 encoding="latin1": n=1000 percent=180.64%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=1 encoding="latin1": n=1000 percent=111.23%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=158.71%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=174.86%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=172.27%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=185.58%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=179.00%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=172.08%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=110.57%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=168.52%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=181.03%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=165.80%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=183.66%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=171.94%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=126.39%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=0 encoding="iso-8859-3": n=1000 percent=131.68%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=171.07%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=180.73%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=171.08%
util/text-decoder.js type="SharedArrayBuffer" fatal=0 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=181.38%
util/text-decoder.js type="ArrayBuffer" fatal=0 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=180.71%
util/text-decoder.js type="Buffer" fatal=0 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=179.90%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=170.00%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=165.23%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=161.41%
util/text-decoder.js type="SharedArrayBuffer" fatal=1 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=187.16%
util/text-decoder.js type="ArrayBuffer" fatal=1 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=176.52%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=123.98%
util/text-decoder.js type="Buffer" fatal=1 ignoreBOM=1 encoding="iso-8859-3": n=1000 percent=128.72%

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Nov 27, 2023
@H4ad H4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2023
@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
@nodejs-github-bot nodejs-github-bot merged commit cd71838 into nodejs:main Dec 4, 2023
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cd71838

@lucshi lucshi deleted the util/text-decoder.js branch December 5, 2023 03:07
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@RafaelGSS
benchmark: update interations and len in benchmark/util/text-decoder.js
fdd8c18 
Fixes: #50571
PR-URL: #50938
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@richardlau
benchmark: update interations and len in benchmark/util/text-decoder.js
6a8ff09 
Fixes: #50571
PR-URL: #50938
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucshi @nodejs-github-bot @UlisesGascon @H4ad