Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: https server close event #5106

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions test/parallel/test-https-close.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
'use strict';
const common = require('../common');
const fs = require('fs');

if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
return;
}
const https = require('https');

const options = {
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
};

var connections = {};

var server = https.createServer(options, function(req, res) {
var interval = setInterval(function() {
res.write('data');
}, 1000);
interval.unref();
});

server.on('connection', function(connection) {
var key = connection.remoteAddress + ':' + connection.remotePort;
connection.on('close', function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: in general, current trend is to favor arrow functions and template strings in new code where possible to do so..

delete connections[key];
});
connections[key] = connection;
});

function shutdown() {
server.close(common.mustCall(function() {}));

for (var key in connections) {
connections[key].destroy();
delete connections[key];
}
}

server.listen(common.PORT, function() {
var requestOptions = {
hostname: '127.0.0.1',
port: common.PORT,
path: '/',
method: 'GET',
rejectUnauthorized: false
};

var req = https.request(requestOptions, function(res) {
res.on('data', function(d) {});
setImmediate(shutdown);
});
req.end();
});