benchmark: update iterations of benchmark/domain/domain-fn-args.js #51408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
|
Reason is the repetition is too small and the data variance is caused by GC activities. |
legendecas
reviewed
Mar 1, 2024
There was a problem hiding this comment.
For reference, the original intention of the benchmark case was to verify the performance of fn.call between the size of the sliced argument array: 8c69d7b.
Co-authored-by: Chengzhong Wu <[email protected]>
legendecas
approved these changes
Mar 4, 2024
legendecas
added
commit-queue
UlisesGascon
approved these changes
Mar 4, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in fde5534 |
targos
pushed a commit
that referenced
this pull request
Mar 7, 2024
Fixes: #50571 PR-URL: #51408 Reviewed-By: Chengzhong Wu <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Fixes: #50571 PR-URL: #51408 Reviewed-By: Chengzhong Wu <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Fixes: #50571 PR-URL: #51408 Reviewed-By: Chengzhong Wu <[email protected]>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
Fixes: nodejs#50571 PR-URL: nodejs#51408 Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50571
Found
40% regression on node20 compared with older version:/luc/node_new$ /home/benchmark/.nvm/versions/node/v16.20.2/bin/node benchmark/domain/domain-fn-args.jsbenchmark@benchmark-S2600WFT:
domain/domain-fn-args.js n=10 args=0: 59,126.81519322643
domain/domain-fn-args.js n=10 args=1: 55,949.690038717185
domain/domain-fn-args.js n=10 args=2: 49,182.34353866962
domain/domain-fn-args.js n=10 args=3: 58,395.18356525954
benchmark@benchmark-S2600WFT:~/luc/node_new$ /home/benchmark/.nvm/versions/node/v20.11.1/bin/node benchmark/domain/domain-fn-args.js
domain/domain-fn-args.js n=10 args=0: 38,578.609704063485
domain/domain-fn-args.js n=10 args=1: 38,735.66780291292
domain/domain-fn-args.js n=10 args=2: 39,472.645456698505
domain/domain-fn-args.js n=10 args=3: 39,021.49694266571