Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(vee-eight-4.9) Replace more deprecated V8 API usage #5204

Closed
wants to merge 4 commits into from

Commits on Feb 18, 2016

  1. Configuration menu
    Copy the full SHA
    23589ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14ba959 View commit details
    Browse the repository at this point in the history
  3. buffer: cleanup CallbackInfo

    Dynamic checks that CallbackInfo holds an ArrayBuffer handle can be
    converted into compiler enforced checks. Removed unused code, and
    other minor cleanup.
    ofrobots committed Feb 18, 2016
    Configuration menu
    Copy the full SHA
    34bf1da View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2016

  1. buffer: replace deprecated SetWeak usage

    Old style SetWeak is now deprecated, and weakness now works like
    phantom references. This means we no longer have a reference to the
    object in the weak callback. We use a kInternalFields style weak
    callback which provides us with the contents of 2 internal fields
    where we can squirrel away the native buffer pointer.
    
    We can no longer neuter the buffer in the weak callback, but that
    should be unnecessary as the object is going to be GC'd during the
    current gc cycle.
    ofrobots committed Feb 24, 2016
    Configuration menu
    Copy the full SHA
    dcecbde View commit details
    Browse the repository at this point in the history