test_runner: fix recursive run #52322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
atlowChemi
approved these changes
Apr 2, 2024
cjihrig
approved these changes
Apr 2, 2024
benjamingr
approved these changes
Apr 2, 2024
github-actions
bot
added
request-ci-failed
Failed to start CI- Validating Jenkins credentials ✘ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/8527079667 |
rluvaton
reviewed
Apr 2, 2024
ggrossetie
reviewed
Apr 3, 2024
panva
added
request-ci
MoLow
force-pushed
the
test-runner-recursive-run
branch
from
d7afa62
to
fe3fca7
Compare
github-actions
bot
removed
the
request-ci
MoLow
force-pushed
the
test-runner-recursive-run
branch
from
fe3fca7
to
f26d3af
Compare
github-actions
bot
removed
the
request-ci
MoLow
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52322 ✔ Done loading data for nodejs/node/pull/52322 ----------------------------------- PR info ------------------------------------ Title test_runner: fix recursive run (#52322) Author Moshe Atlow (@MoLow) Branch MoLow:test-runner-recursive-run -> nodejs:main Labels needs-ci, test_runner Commits 1 - test_runner: fix recursive run Committers 1 - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/52322 Reviewed-By: Chemi Atlow Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52322 Reviewed-By: Chemi Atlow Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test_runner: fix recursive run ℹ This PR was created on Tue, 02 Apr 2024 11:11:25 GMT ✔ Approvals: 3 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/52322#pullrequestreview-1973575013 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/52322#pullrequestreview-1974222094 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52322#pullrequestreview-1974360473 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-04T10:38:43Z: https://ci.nodejs.org/job/node-test-pull-request/58103/ - Querying data for job/node-test-pull-request/58103/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8554105787 |
aduh95
approved these changes
Apr 4, 2024
aduh95
removed
the
commit-queue-failed
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 433bd1b |
|
thanks @aduh95 🙏 |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52322 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52322 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52304
added a warning so users can know what is going on, and added a call to
postRunso the tests stream will end