crypto: move DEP0182 to runtime deprecation #52552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a runtime deprecation for using GCM authentication tags that are shorter than the cipher's block size, unless the user specified the authTagLength option. This behavior has been doc-only deprecated since 8f61b65. Refs: nodejs#52327 Refs: nodejs#52345
tniessen
added
crypto
|
Review requested:
|
nodejs-github-bot
added
c++
marco-ippolito
approved these changes
Apr 16, 2024
benjamingr
approved these changes
Apr 16, 2024
anonrig
approved these changes
Apr 16, 2024
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
added
commit-queue-failed
This comment was marked as off-topic.
This comment was marked as off-topic.
tniessen
removed
the
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
Apr 20, 2024
RafaelGSS
approved these changes
Apr 23, 2024
|
This PR seems ready for commit-queue, shall we? |
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ff82606 |
|
@RedYetiDev This PR is supposed to be released with Node.js 23 in October. There is nothing wrong with keeping it open for feedback and/or reviews. |
|
Ahh okay, sorry if I rushed anything. Great work! |
aduh95
pushed a commit
that referenced
this pull request
Apr 30, 2024
This introduces a runtime deprecation for using GCM authentication tags that are shorter than the cipher's block size, unless the user specified the authTagLength option. This behavior has been doc-only deprecated since 8f61b65. Refs: #52327 Refs: #52345 PR-URL: #52552 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
This introduces a runtime deprecation for using GCM authentication tags that are shorter than the cipher's block size, unless the user specified the authTagLength option. This behavior has been doc-only deprecated since 8f61b65. Refs: nodejs#52327 Refs: nodejs#52345 PR-URL: nodejs#52552 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a runtime deprecation for using GCM authentication tags that are shorter than the cipher's block size, unless the user specified the authTagLength option. This behavior has been doc-only deprecated since 8f61b65.
I'd suggest to release this in Node.js 23. If it turns out to break some use cases, we can re-evaluate before moving to end-of-life.
Refs: #52327
Refs: #52345