Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: cast to v8::Value before using v8::EmbedderGraph::V8Node #52638

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

joyeecheung
Copy link
Member

This is required to disambiguate the call site for an upstream patch to support v8::Data in traced references and pass the Node.js integration in the V8 CI. When that lands in the upstream we can implement V8Node(const v8::Localv8::Data) in a follow-up.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888

This is required to disambiguate the call site for an upstream
patch to support v8::Data in traced references and pass the
Node.js integration in the V8 CI. When that lands in the upstream
we can implement V8Node(const v8::Local<v8::Data>) in a
follow-up.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 22, 2024
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7b2e3b8 into nodejs:main Apr 25, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7b2e3b8

pthier pushed a commit to v8/node that referenced this pull request Apr 29, 2024
aduh95 pushed a commit that referenced this pull request Apr 29, 2024
This is required to disambiguate the call site for an upstream
patch to support v8::Data in traced references and pass the
Node.js integration in the V8 CI. When that lands in the upstream
we can implement V8Node(const v8::Local<v8::Data>) in a
follow-up.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888
PR-URL: #52638
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
This is required to disambiguate the call site for an upstream
patch to support v8::Data in traced references and pass the
Node.js integration in the V8 CI. When that lands in the upstream
we can implement V8Node(const v8::Local<v8::Data>) in a
follow-up.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888
PR-URL: #52638
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
This is required to disambiguate the call site for an upstream
patch to support v8::Data in traced references and pass the
Node.js integration in the V8 CI. When that lands in the upstream
we can implement V8Node(const v8::Local<v8::Data>) in a
follow-up.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888
PR-URL: #52638
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
This is required to disambiguate the call site for an upstream
patch to support v8::Data in traced references and pass the
Node.js integration in the V8 CI. When that lands in the upstream
we can implement V8Node(const v8::Local<v8::Data>) in a
follow-up.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888
PR-URL: nodejs#52638
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants