Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: define NOMINMAX in common.gypi #52794

Merged
merged 1 commit into from
May 4, 2024
Merged

build: define NOMINMAX in common.gypi #52794

merged 1 commit into from
May 4, 2024

Commits on May 2, 2024

  1. build: define NOMINMAX in common.gypi 

    V8 and Node.js had defined `NOMINMAX` on Windows for a long time.  In
recent changes, V8 added `std::numeric_limits::min` usages in its
header files which caused addons without `NOMINMAX` defines failed
to compile.

Define `NOMINMAX` in common.gypi so that addons can be compiled with
the latest V8 header files.
    @legendecas
    legendecas committed May 2, 2024
    Configuration menu
    Copy the full SHA
    833f447 View commit details
    Browse the repository at this point in the history