Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.20.3 proposal #53028

Merged
merged 41 commits into from
May 21, 2024
Merged

v18.20.3 proposal #53028

merged 41 commits into from
May 21, 2024

Commits on Apr 17, 2024

  1. test: skip test for dynamically linked OpenSSL

    As a temporary measure to unblock the CI, skip the RSA implicit
    rejection test when Node.js is built against a dynamically linked
    OpenSSL.
    
    PR-URL: #52542
    Refs: #52537
    Refs: nodejs-private/node-private#525
    Refs: https://hackerone.com/reports/2269177
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    richardlau committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c60cd67 View commit details
    Browse the repository at this point in the history
  2. deps: V8: cherry-pick d15d49b09dc7

    Original commit message:
    
        Make bitfields only as wide as necessary for enums
    
        clang now complains when a BitField for an enum is too wide.
        We could suppress this, but it seems kind of useful from an
        uninformed distance, so I made a few bitfields smaller instead.
    
        (For AddressingMode, since its size is target-dependent, I added
        an explicit underlying type to the enum instead, which suppresses
        the diag on a per-enum basis.)
    
        This is without any understanding of the code I'm touching.
        Especially the change in v8-internal.h feels a bit risky to me.
    
        Bug: chromium:1348574
        Change-Id: I73395de593045036b72dadf4e3147b5f7e13c958
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3794708
        Commit-Queue: Nico Weber <[email protected]>
        Reviewed-by: Leszek Swirski <[email protected]>
        Reviewed-by: Hannes Payer <[email protected]>
        Auto-Submit: Nico Weber <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#82109}
    
    Refs: v8/v8@d15d49b
    PR-URL: #52337
    Fixes: #52230
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Bo98 authored and richardlau committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    678641f View commit details
    Browse the repository at this point in the history
  3. http: remove closeIdleConnections function while calling server close

    Correcting the #50194 backporting mistake.
    closeIdleConnections shouldnot be called while server.close in node v18.
    This behavior is for node v19 and above.
    
    Fixes: #52330
    Fixes: #51677
    PR-URL: #52336
    Refs: #50194
    Reviewed-By: Nitzan Uziely <[email protected]>
    kumarrishav authored and richardlau committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6689a98 View commit details
    Browse the repository at this point in the history
  4. test: deflake test-http-regr-gh-2928

    Hard code the value of the host parameter to `common.localhostIPv4` in
    `server.listen()` and `net.connect()`. This
    
    1. ensures that the client `socket._handle` is not reinitialized during
       connection due to the family autodetection algorithm, preventing
       `parser.consume()` from being called with an invalid `socket._handle`
       parameter.
    2. works around an issue in the FreeBSD 12 machine where the stress test
       is run where some sockets get stuck after connection.
    
    PR-URL: #49574
    Backport-PR-URL: #52384
    Closes: #49565
    Fixes: #49564
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    lpinca authored and richardlau committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5186e45 View commit details
    Browse the repository at this point in the history
  5. test: reduce the number of requests and parsers

    The maximum number of parsers in the free list is set to 1000. However
    the test does not need to use this maximum. Reduce it to 50.
    
    Refs: #50228 (comment)
    PR-URL: #50240
    Backport-PR-URL: #52384
    Fixes: #49564
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    lpinca authored and richardlau committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5cec2ef View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. doc: add release key for marco-ippolito

    PR-URL: #52257
    Refs: nodejs/Release#984
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    marco-ippolito authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5e93eae View commit details
    Browse the repository at this point in the history
  2. deps: update nghttp2 to 1.58.0

    PR-URL: #50441
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e28316d View commit details
    Browse the repository at this point in the history
  3. deps: update nghttp2 to 1.59.0

    PR-URL: #51581
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3c9dbbf View commit details
    Browse the repository at this point in the history
  4. deps: update nghttp2 to 1.60.0

    PR-URL: #51948
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1b6fa70 View commit details
    Browse the repository at this point in the history
  5. deps: update nghttp2 to 1.61.0

    PR-URL: #52395
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a9f3b9d View commit details
    Browse the repository at this point in the history
  6. deps: update simdutf to 4.0.9

    PR-URL: #51655
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b56f66e View commit details
    Browse the repository at this point in the history
  7. deps: update simdutf to 5.0.0

    PR-URL: #52138
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    lemire authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    be30309 View commit details
    Browse the repository at this point in the history
  8. deps: update simdutf to 5.2.3

    PR-URL: #52381
    Refs: #51670
    Reviewed-By: Daniel Lemire <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    anonrig authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5114cbe View commit details
    Browse the repository at this point in the history
  9. deps: update simdutf to 5.2.4

    PR-URL: #52473
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    209823d View commit details
    Browse the repository at this point in the history
  10. deps: upgrade npm to 10.5.1

    PR-URL: #52351
    Reviewed-By: Luke Karrys <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    npm-cli-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    052b0ba View commit details
    Browse the repository at this point in the history
  11. deps: update corepack to 0.26.0

    PR-URL: #52027
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b199889 View commit details
    Browse the repository at this point in the history
  12. deps: update ada to 2.7.7

    PR-URL: #52028
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7a8c7b6 View commit details
    Browse the repository at this point in the history
  13. deps: update acorn to 8.11.2

    PR-URL: #50460
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9500817 View commit details
    Browse the repository at this point in the history
  14. deps: update acorn-walk to 8.3.0

    PR-URL: #50457
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c86550e View commit details
    Browse the repository at this point in the history
  15. deps: update acorn-walk to 8.3.1

    PR-URL: #50457
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    dddb7eb View commit details
    Browse the repository at this point in the history
  16. deps: update acorn to 8.11.3

    PR-URL: #51317
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    12f28f3 View commit details
    Browse the repository at this point in the history
  17. deps: update acorn-walk to 8.3.2

    PR-URL: #51457
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    nodejs-github-bot authored and richardlau committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    2c53ff3 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. node-api: make tsfn accept napi_finalize once more

    The thread-safe function's finalizer is not called in conjunction with
    the garbage collection of a JS value. In fact, it keeps a strong
    reference to the JS function it is expected to call. Thus, it is safe
    to make calls that affect GC state from its body.
    
    PR-URL: #51801
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    gabrielschulhof authored and richardlau committed May 7, 2024
    Configuration menu
    Copy the full SHA
    71616e8 View commit details
    Browse the repository at this point in the history
  2. deps: upgrade npm to 10.5.2

    PR-URL: #52458
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    npm-cli-bot authored and richardlau committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8fd5a35 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. deps: update ngtcp2 and nghttp3

    PR-URL: #51291
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    jasnell authored and richardlau committed May 10, 2024
    Configuration menu
    Copy the full SHA
    28c0c78 View commit details
    Browse the repository at this point in the history
  2. deps: add nghttp3/**/.deps to .gitignore

    PR-URL: #51400
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    lpinca authored and richardlau committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1aa9da4 View commit details
    Browse the repository at this point in the history
  3. deps: update ngtcp2 to 1.1.0

    PR-URL: #51319
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    nodejs-github-bot authored and richardlau committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3034968 View commit details
    Browse the repository at this point in the history
  4. deps: update ngtcp2 to 1.2.0

    PR-URL: #51584
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and richardlau committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1f489a3 View commit details
    Browse the repository at this point in the history
  5. deps: update ngtcp2 to 1.3.0

    PR-URL: #51796
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    nodejs-github-bot authored and richardlau committed May 10, 2024
    Configuration menu
    Copy the full SHA
    78f84eb View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. deps: upgrade npm to 10.7.0

    PR-URL: #52767
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    npm-cli-bot authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7f5dd44 View commit details
    Browse the repository at this point in the history
  2. deps: update corepack to 0.28.0

    PR-URL: #52616
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    nodejs-github-bot authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    14e857b View commit details
    Browse the repository at this point in the history
  3. deps: update c-ares to 1.28.1

    PR-URL: #52285
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e4ea2db View commit details
    Browse the repository at this point in the history
  4. deps: update ada to 2.7.8

    PR-URL: #52517
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    nodejs-github-bot authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    af3e320 View commit details
    Browse the repository at this point in the history
  5. deps: update zlib to 1.3.0.1-motley-24342f6

    PR-URL: #52123
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    nodejs-github-bot authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    755399d View commit details
    Browse the repository at this point in the history
  6. deps: update zlib to 1.3.0.1-motley-24c07df

    PR-URL: #52199
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    1152d7f View commit details
    Browse the repository at this point in the history
  7. deps: update zlib to 1.3.0.1-motley-7d77fb7

    PR-URL: #52516
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0c260e1 View commit details
    Browse the repository at this point in the history
  8. doc: remove ableist language from crypto

    PR-URL: #52063
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Akhil Marsonya <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    10xLaCroixDrinker authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    1147fee View commit details
    Browse the repository at this point in the history
  9. test: v8: Add test-linux-perf-logger test suite

    Cherry-picked from 9c714d8
    
    PR-URL: #50352
    Backport-PR-URL: #52925
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    lukealbao authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    351ef18 View commit details
    Browse the repository at this point in the history
  10. test: skip v8-updates/test-linux-perf

    Refs: #50079
    PR-URL: #49639
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    targos authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e5fc8ec View commit details
    Browse the repository at this point in the history
  11. src: avoid draining platform tasks at FreeEnvironment

    At the point of `FreeEnvironment` and onwards, no JavaScript execution
    associated with the Environment should be triggered.
    
    Avoid draining platform tasks that can trigger JavaScript execution in
    `FreeEnvironment`. The holder of `node::Environment` should immediately
    call `node::MultiIsolatePlatform::UnregisterIsolate` and
    `v8::Isolate::Dispose` to cancel pending foreground tasks and join
    concurrent tasks after the environment was freed.
    
    `NodePlatform` can properly handle the case in `RunForegroundTask` when
    an Isolate out-lives its associated `node::Environment`.
    
    PR-URL: #51290
    Fixes: #47748
    Fixes: #49344
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    legendecas authored and richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d9d9e62 View commit details
    Browse the repository at this point in the history
  12. 2024-05-21, Version 18.20.3 'Hydrogen' (LTS)

    Notable changes:
    
    This release fixes a regression introduced in Node.js 18.19.0 where
    `http.server.close()` was incorrectly closing idle connections.
    
    A fix has also been included for compiling Node.js from source with
    newer versions of Clang.
    
    The list of keys used to sign releases has been synchronized with the
    current list from the `main` branch.
    
    Updated dependencies:
    
    - acorn updated to 8.11.3.
    - acorn-walk updated to 8.3.2.
    - ada updated to 2.7.8.
    - c-ares updated to 1.28.1.
    - corepack updated to 0.28.0.
    - nghttp2 updated to 1.61.0.
    - ngtcp2 updated to 1.3.0.
    - npm updated to 10.7.0. Includes a fix from [email protected] to limit the
      number of open connections.
    - simdutf updated to 5.2.4.
    - zlib updated to 1.3.0.1-motley-7d77fb7.
    
    PR-URL: #53028
    richardlau committed May 16, 2024
    Configuration menu
    Copy the full SHA
    64903b1 View commit details
    Browse the repository at this point in the history